Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check_and_failed option to pacemaker_cluster module #52

Closed

Conversation

matbu
Copy link

@matbu matbu commented Mar 26, 2020

In order to not set a state to a cluster while the
cluster in not in the expected state we need to check
it and fail, or poll until the cluster is in a required
state, example:

  • name: Check pacemaker cluster running before upgrade
    pacemaker_cluster: state=online check_and_fail=true
    async: 30
    poll: 4
SUMMARY
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

In order to not set a state to a cluster while the
cluster in not in the expected state we need to check
it and fail, or poll until the cluster is in a required
state, example:
- name: Check pacemaker cluster running before upgrade
  pacemaker_cluster: state=online check_and_fail=true
  async: 30
  poll: 4
@felixfontein
Copy link
Collaborator

Please add a changelog fragment in changelogs/fragments/.

(You probably have to rebase with current master to see that directory. You can also simply create it yourself without rebasing; git does not care about directories, only about files.)

In order to not set a state to a cluster while the
cluster in not in the expected state we need to check
it and fail, or poll until the cluster is in a required
state, example:
- name: Check pacemaker cluster running before upgrade
  pacemaker_cluster: state=online check_and_fail=true
  async: 30
  poll: 4
@matbu
Copy link
Author

matbu commented Apr 2, 2020

@felixfontein hm I rebased my fork, but I probably did mistake, I'm getting all commits from my last push :/

@felixfontein
Copy link
Collaborator

You need to update your local master first, probably, and then rebase against master. If you do git rebase -i master, remove all commits from the list which don't belong to your PR.

@gundalow
Copy link
Contributor

bot_skip

@gundalow gundalow added the ci_verified Push fixes to PR branch to re-run CI label Apr 18, 2020
@gundalow
Copy link
Contributor

@matbu Git can be a pain sometimes, it's easy to get it into a confused state.

You should be able to git pull --rebase upstream master.

We have this guide for ansible/ansible https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html though remember that

  1. You'll need to refer to community.general instead
  2. This is using the master branch, not devel

@gundalow gundalow added the pr_day Has been reviewed during a PR review Day. https://github.com/ansible/community/issues/407 label Jun 17, 2020
@felixfontein felixfontein changed the base branch from master to main July 6, 2020 06:54
@Andersson007
Copy link
Contributor

@matbu i'll close the PR. Feel free to create a new one instead (or claim to reopen this if you want to rebase), thanks!

amenzhinsky pushed a commit to amenzhinsky/community.general that referenced this pull request Nov 13, 2020
* Applying changes made in ansible/ansible

Changes were made on `grafana_dashboard` after a bugfix. Modules paramters
now have forbidden keywords like `message`.

See ansible/ansible#60051

* bsr: new rule in mutually_exclusive-unknown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci_verified Push fixes to PR branch to re-run CI pr_day Has been reviewed during a PR review Day. https://github.com/ansible/community/issues/407
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants