Bugfix - EnvironmentError with wrong indentation #5202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error also had a wrong indentation. See previous setup with correct setup: https://github.com/ansible-collections/community.general/blob/6a7811f6963ad1f5f92342b786e70a809e1c9e08/plugins/modules/system/listen_ports_facts.py
ansibullbot
added
bug
felixfontein
added
check-before-release
|
Thanks for your contribution! Can you please add a changelog fragment? Thanks. |
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
ci_verified
ansibullbot
removed
ci_verified
felixfontein
reviewed
Sep 3, 2022
changelogs/fragments/5202-bugfix-environmentError-wrong-indentation.yaml
Outdated
Show resolved
Hide resolved
felixfontein
approved these changes
Sep 3, 2022
felixfontein
removed
the
check-before-release
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5221 🤖 @patchback |
|
@PKehnel thanks for fixing this! |
patchback bot
pushed a commit
that referenced
this pull request
Sep 3, 2022
* The EnvironmentError is now handled in the splid_pid_name function. The error also had a wrong indentation. See previous setup with correct setup: https://github.com/ansible-collections/community.general/blob/6a7811f6963ad1f5f92342b786e70a809e1c9e08/plugins/modules/system/listen_ports_facts.py * Add changelog fragment * Sanity Check failed before * Update changelogs/fragments/5202-bugfix-environmentError-wrong-indentation.yaml Co-authored-by: Paul-Kehnel <paul.kehnel@ocean.ibm.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 36a7939)
felixfontein
pushed a commit
that referenced
this pull request
Sep 3, 2022
* The EnvironmentError is now handled in the splid_pid_name function. The error also had a wrong indentation. See previous setup with correct setup: https://github.com/ansible-collections/community.general/blob/6a7811f6963ad1f5f92342b786e70a809e1c9e08/plugins/modules/system/listen_ports_facts.py * Add changelog fragment * Sanity Check failed before * Update changelogs/fragments/5202-bugfix-environmentError-wrong-indentation.yaml Co-authored-by: Paul-Kehnel <paul.kehnel@ocean.ibm.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 36a7939) Co-authored-by: PKehnel <ga65coy@mytum.de>
bratwurzt
pushed a commit
to bratwurzt/community.general
that referenced
this pull request
Nov 7, 2022
…#5202) * The EnvironmentError is now handled in the splid_pid_name function. The error also had a wrong indentation. See previous setup with correct setup: https://github.com/ansible-collections/community.general/blob/6a7811f6963ad1f5f92342b786e70a809e1c9e08/plugins/modules/system/listen_ports_facts.py * Add changelog fragment * Sanity Check failed before * Update changelogs/fragments/5202-bugfix-environmentError-wrong-indentation.yaml Co-authored-by: Paul-Kehnel <paul.kehnel@ocean.ibm.com> Co-authored-by: Felix Fontein <felix@fontein.de>
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #4953
As part of the above merge request a minor bug was introduced.
elsestatement was one too far.elsestatement is now handled in the function:split_pid_nameISSUE TYPE
COMPONENT NAME
listen port facts
ADDITIONAL INFORMATION
The else statement:
EnvironmentError('Could not get process information for the listening ports.')can be removed. The purpose was to checkif conns and pidsexists and else throw the error.See previous usage line in older version 173 / 194: https://github.com/ansible-collections/community.general/blob/6a7811f6963ad1f5f92342b786e70a809e1c9e08/plugins/modules/system/listen_ports_facts.py
This is now handled in the
split_pid_namefunction.