[opentelemetry][callback] support opentelemetry-api 1.13 #5342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v1v
commented
Oct 6, 2022
plugins/callback/opentelemetry.py
Outdated
Comment on lines
143
to
144
| if OTEL_LIBRARY_TIME_NS_ERROR: | ||
| self.start = int(time.time() * 1e9) |
There was a problem hiding this comment.
This case should not happen IIUC, since python 3.6 is not supported in opentelemetry-api 1.13, but better play safe
1 task
ansibullbot
added
bug
|
I tested it out in my local instance and it worked as expected |
ansibullbot
added
the
needs_revision
felixfontein
added
check-before-release
felixfontein
reviewed
Oct 8, 2022
changelogs/fragments/5342-opentelemetry_bug_fix_opentelemetry-api-1.13.yml
Outdated
Show resolved
Hide resolved
…api-1.13.yml Co-authored-by: Felix Fontein <felix@fontein.de>
ansibullbot
removed
the
needs_revision
felixfontein
approved these changes
Oct 10, 2022
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
ansibullbot
added
needs_ci
felixfontein
approved these changes
Oct 16, 2022
ansibullbot
removed
the
needs_ci
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Felix Fontein <felix@fontein.de>
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 1, 2022
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
opentelemetry-api 1.13removed support for_time_ns, this change will allow to fallback to the previous implementation of synthetically creating a time_ns when using <=python 3.6withopentelemetry-api 1.13, if that's even possible...ISSUE TYPE
COMPONENT NAME
plugins/callback/opentelemetry.pyADDITIONAL INFORMATION
Closes #5315