Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-5] Warn about using internal FQCNs for modules and actions #5373

Merged
merged 1 commit into from
Nov 3, 2022
Merged

[stable-5] Warn about using internal FQCNs for modules and actions #5373

merged 1 commit into from
Nov 3, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

For background see ansible-community/community-topics#147.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

changelog, README

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Oct 26, 2022
@felixfontein felixfontein changed the base branch from main to stable-5 November 3, 2022 06:08
@felixfontein felixfontein changed the title Warn about using internal FQCNs for modules and actions [stable-5] Warn about using internal FQCNs for modules and actions Nov 3, 2022
@felixfontein
Copy link
Collaborator Author

Since main has already changed, this should appear in the c.g 5.x.y changelog. The next 5.x.y release is a bugfix release, but since this deprecation is informational only including it in a bugfix release is OK.

@felixfontein felixfontein reopened this Nov 3, 2022
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 3, 2022
@felixfontein felixfontein merged commit 24a4d6e into ansible-collections:stable-5 Nov 3, 2022
@felixfontein felixfontein deleted the warning-fqcns branch November 3, 2022 06:41
@patchback

This comment was marked as outdated.

Sign in to view
@felixfontein
Copy link
Collaborator Author

@Andersson007 thanks for reviewing this!

@felixfontein felixfontein removed backport-5 check-before-release PR will be looked at again shortly before release and merged if possible. labels Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andersson007 Andersson007 Andersson007 approved these changes

@russoz russoz Awaiting requested review from russoz

Assignees
No one assigned
Labels
docs stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixfontein @Andersson007 @ansibullbot