Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archive: better expose requirements #5392

Merged
merged 4 commits into from
Oct 21, 2022
Merged

archive: better expose requirements #5392

merged 4 commits into from
Oct 21, 2022

Conversation

felixfontein
Copy link
Collaborator

@felixfontein felixfontein commented Oct 20, 2022 •
edited

SUMMARY

Ref: #5391.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

archive

@felixfontein felixfontein mentioned this pull request Oct 20, 2022
Closed
1 task
@ansibullbot
Copy link
Collaborator

cc @bendoh
click here for bot help

@github-actions
Copy link

github-actions bot commented Oct 20, 2022 •
edited

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@gotmax23
Copy link
Contributor 

    - Requires C(tarfile), C(zipfile), C(gzip), and C(bz2) packages on target host. These are all part of the Python standard library for Python 2 and 3.

Am I missing something? Why would we list parts of the stdlib as requirements when they are universally available?

@felixfontein
Copy link
Collaborator Author

I once heard that there are some distributions which remove parts of the stdlib (resp. require extra packages to be installed for them). I guess this explicit list is there because of that. I guess it might suffice to keep that list in the Notes section though. WDYT? (That statement used to be there since the very first initial commit (ansible/ansible-modules-extras#2323).)

@felixfontein @gotmax23
Update plugins/modules/files/archive.py
bf71e9a 
Co-authored-by: Maxwell G <gotmax@e.email>
@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Oct 20, 2022
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Oct 20, 2022
@felixfontein felixfontein merged commit a023f2a into ansible-collections:main Oct 21, 2022
@patchback
Copy link

patchback bot commented Oct 21, 2022 •
edited

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/a023f2a344aae28d4441e0f6923b8144fe65c1ac/pr-5392

Backported as #5401

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the archive-docs branch October 21, 2022 05:08
patchback bot pushed a commit that referenced this pull request Oct 21, 2022
@felixfontein @patchback
archive: better expose requirements (#5392)
807550e 
* Better expose requirements.

* Move sentence back to notes.

* Update plugins/modules/files/archive.py

Co-authored-by: Maxwell G <gotmax@e.email>

* Break line.

Co-authored-by: Maxwell G <gotmax@e.email>
(cherry picked from commit a023f2a)
@patchback patchback bot mentioned this pull request Oct 21, 2022
Merged
@felixfontein
Copy link
Collaborator Author

@gotmax23 thanks for reviewing and the suggestions!

@patchback
Copy link

patchback bot commented Oct 21, 2022 •
edited

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/a023f2a344aae28d4441e0f6923b8144fe65c1ac/pr-5392

Backported as #5402

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 21, 2022
@felixfontein @patchback
archive: better expose requirements (#5392)
f26995f 
* Better expose requirements.

* Move sentence back to notes.

* Update plugins/modules/files/archive.py

Co-authored-by: Maxwell G <gotmax@e.email>

* Break line.

Co-authored-by: Maxwell G <gotmax@e.email>
(cherry picked from commit a023f2a)
@patchback patchback bot mentioned this pull request Oct 21, 2022
Merged
felixfontein added a commit that referenced this pull request Oct 21, 2022
@patchback @felixfontein
archive: better expose requirements (#5392) (#5401)
e42770d 
* Better expose requirements.

* Move sentence back to notes.

* Update plugins/modules/files/archive.py

Co-authored-by: Maxwell G <gotmax@e.email>

* Break line.

Co-authored-by: Maxwell G <gotmax@e.email>
(cherry picked from commit a023f2a)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Oct 21, 2022
@patchback @felixfontein
archive: better expose requirements (#5392) (#5402)
9ed0603 
* Better expose requirements.

* Move sentence back to notes.

* Update plugins/modules/files/archive.py

Co-authored-by: Maxwell G <gotmax@e.email>

* Break line.

Co-authored-by: Maxwell G <gotmax@e.email>
(cherry picked from commit a023f2a)

Co-authored-by: Felix Fontein <felix@fontein.de>
russoz pushed a commit to russoz-ansible/community.general that referenced this pull request Nov 5, 2022
@felixfontein @gotmax23 @russoz
archive: better expose requirements (ansible-collections#5392)
07b3f81 
* Better expose requirements.

* Move sentence back to notes.

* Update plugins/modules/files/archive.py

Co-authored-by: Maxwell G <gotmax@e.email>

* Break line.

Co-authored-by: Maxwell G <gotmax@e.email>
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@felixfontein @gotmax23
archive: better expose requirements (ansible-collections#5392)
f2f40b1 
* Better expose requirements.

* Move sentence back to notes.

* Update plugins/modules/files/archive.py

Co-authored-by: Maxwell G <gotmax@e.email>

* Break line.

Co-authored-by: Maxwell G <gotmax@e.email>
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@felixfontein @gotmax23
archive: better expose requirements (ansible-collections#5392)
3a9e3af 
* Better expose requirements.

* Move sentence back to notes.

* Update plugins/modules/files/archive.py

Co-authored-by: Maxwell G <gotmax@e.email>

* Break line.

Co-authored-by: Maxwell G <gotmax@e.email>
russoz pushed a commit to russoz-ansible/community.general that referenced this pull request Nov 10, 2022
@felixfontein @gotmax23 @russoz
archive: better expose requirements (ansible-collections#5392)
48089d3 
* Better expose requirements.

* Move sentence back to notes.

* Update plugins/modules/files/archive.py

Co-authored-by: Maxwell G <gotmax@e.email>

* Break line.

Co-authored-by: Maxwell G <gotmax@e.email>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotmax23 gotmax23 gotmax23 approved these changes

Assignees
No one assigned
Labels
docs_only docs files has_issue module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@felixfontein @ansibullbot @gotmax23