Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archive: do not crash when lzma is not around #5393

Merged
merged 1 commit into from Oct 20, 2022
Merged

archive: do not crash when lzma is not around #5393

merged 1 commit into from Oct 20, 2022

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #5391.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

archive

@felixfontein felixfontein mentioned this pull request Oct 20, 2022
Closed
1 task
@ansibullbot
Copy link
Collaborator

cc @bendoh
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug files has_issue integration tests/integration module module plugins plugin (any type) tests tests labels Oct 20, 2022
bendoh
bendoh approved these changes Oct 20, 2022
View reviewed changes
Copy link

@bendoh bendoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this!

@felixfontein felixfontein merged commit 5aa1e58 into ansible-collections:main Oct 20, 2022
@patchback
Copy link

patchback bot commented Oct 20, 2022 •
edited

Backport to stable-4: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4/5aa1e587496c906f5985d8c294ab23c2d9a4c818/pr-5393

Backported as #5397

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the archive-fix branch October 20, 2022 18:32
@felixfontein
Copy link
Collaborator Author

@bendoh thanks for reviewing this!

patchback bot pushed a commit that referenced this pull request Oct 20, 2022
@felixfontein @patchback
Do not crash when lzma is not around. (#5393)
7f2ca54 
(cherry picked from commit 5aa1e58)
@patchback patchback bot mentioned this pull request Oct 20, 2022
Merged
@patchback
Copy link

patchback bot commented Oct 20, 2022 •
edited

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/5aa1e587496c906f5985d8c294ab23c2d9a4c818/pr-5393

Backported as #5398

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 20, 2022
@felixfontein @patchback
Do not crash when lzma is not around. (#5393)
d2ab368 
(cherry picked from commit 5aa1e58)
@patchback patchback bot mentioned this pull request Oct 20, 2022
Merged
felixfontein added a commit that referenced this pull request Oct 20, 2022
@patchback @felixfontein
Do not crash when lzma is not around. (#5393) (#5397)
1b78f18 
(cherry picked from commit 5aa1e58)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Oct 20, 2022
@patchback @felixfontein
Do not crash when lzma is not around. (#5393) (#5398)
e2fa11b 
(cherry picked from commit 5aa1e58)

Co-authored-by: Felix Fontein <felix@fontein.de>
russoz pushed a commit to russoz-ansible/community.general that referenced this pull request Nov 5, 2022
@felixfontein @russoz
Do not crash when lzma is not around. (ansible-collections#5393)
865729c
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@felixfontein
Do not crash when lzma is not around. (ansible-collections#5393)
18f0a31
bratwurzt pushed a commit to bratwurzt/community.general that referenced this pull request Nov 7, 2022
@felixfontein
Do not crash when lzma is not around. (ansible-collections#5393)
3900ba8
@trux-bot trux-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@lumiere-bot lumiere-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
@ergho-bot ergho-bot bot mentioned this pull request Nov 7, 2022
Merged
1 task
This was referenced Nov 20, 2022
Closed
Closed
Closed
Closed
Merged
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
Merged
This was referenced Dec 1, 2022
Open
Closed
@renovate renovate bot mentioned this pull request Dec 14, 2022
Closed
1 task
@renovate renovate bot mentioned this pull request Jan 1, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendoh bendoh bendoh approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug files has_issue integration tests/integration module module plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

community.general.archive requires lzma module when format != xz when a dest file exists
3 participants
@felixfontein @ansibullbot @bendoh