Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5369/baa8bd52 backport][stable-4] pkgng: fix error-handling when upgrading all #5410

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 23, 2022

This is a backport of PR #5369 as merged into main (baa8bd5).

SUMMARY

The return code of the command was being ignored when upgrading all packages.

Fixes #5363

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pkgng

* pkgng: fix error-handling when upgrading all

* provide for rc=1 in check_mode + test

* fix name of task in test

* add changelog fragment

(cherry picked from commit baa8bd5)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug integration tests/integration module module new_contributor Help guide this first time contributor os packaging plugins plugin (any type) tests tests needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Oct 23, 2022
@felixfontein
Copy link
Collaborator

I'm giving up on CI. This should pass, and if it does not, we'll find out tomorrow during the nightly runs.

@felixfontein felixfontein merged commit 557594c into stable-4 Oct 23, 2022
@felixfontein felixfontein deleted the patchback/backports/stable-4/baa8bd52ab7fd08b3b0b05880a43d8b45e6c7dc6/pr-5369 branch October 23, 2022 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug integration tests/integration module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor os packaging plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants