[PR #5350/fa924aae backport][stable-5] Prepare un-flatmapping #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Add module name into fixtures directory name. * Rename conftest.py to avoid collisions. * Match filenames inside directories. (cherry picked from commit fa924aa)
Merged
|
@patchback[bot] This PR was evaluated as a potentially problematic PR for the following reasons:
Such PR can only be merged by human. Contact a Core team member to review this PR on IRC: |
ansibullbot
added
backport
bug
felixfontein
deleted the
patchback/backports/stable-5/fa924aae31c1675bcf4adb2a9ac56711af71f5eb/pr-5350
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #5350 as merged into main (fa924aa).
SUMMARY
Prepares un-flatmapping. When collapsing the tests/unit/plugins/modules directory tree, there are some clashes because there are different
conftest.pyfiles in the tree structure. This PR renames theseconftest.pyfiles (and adjusts the importing code), as well as renaming the single currently existingfixturesdirectory by prepending it with the module name.With these changes, https://gist.github.com/felixfontein/3123dcdf446c9e140949a0589cceb99d can remove flatmapping and at least the Python 3.10 unit tests still pass :)
Ref: ansible-community/community-topics#147
ISSUE TYPE
COMPONENT NAME
unit tests