Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apk: Add no-cache option #548

Merged
merged 2 commits into from Jun 23, 2020
Merged

apk: Add no-cache option #548

merged 2 commits into from Jun 23, 2020

Conversation

aminvakil
Copy link
Contributor

SUMMARY

Add --no-cache option to apk module.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

apk

@ansibullbot
Copy link
Collaborator

cc @tdtrask
click here for bot help

@ansibullbot ansibullbot added affects_2.10 community_review feature This issue/PR relates to a feature request module module needs_triage new_contributor Help guide this first time contributor os packaging plugins plugin (any type) labels Jun 21, 2020
@aminvakil
Copy link
Contributor Author

aminvakil commented Jun 21, 2020 •
edited

https://app.shippable.com/github/ansible-collections/community.general/runs/2287/1/tests

I cannot understand why EXAMPLES is not a valid yaml file.

@aminvakil
Copy link
Contributor Author

Other failures should be fixed by merging #549

@ansibullbot
Copy link
Collaborator

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

plugins/modules/packaging/os/apk.py:132:5: invalid-examples: EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

plugins/modules/packaging/os/apk.py:67:5: unparsable-with-libyaml: while scanning a simple key - could not find expected ':'
plugins/modules/packaging/os/apk.py:132:5: error: EXAMPLES: syntax error: could not find expected ':' (syntax)

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

plugins/modules/packaging/os/apk.py:132:5: invalid-examples: EXAMPLES is not valid YAML

The test ansible-test sanity --test yamllint [explain] failed with 2 errors:

plugins/modules/packaging/os/apk.py:132:5: error: EXAMPLES: syntax error: could not find expected ':' (syntax)
plugins/modules/packaging/os/apk.py:132:5: unparsable-with-libyaml: while scanning a simple key - could not find expected ':'

click here for bot help

felixfontein
felixfontein reviewed Jun 21, 2020
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
plugins/modules/packaging/os/apk.py Show resolved Hide resolved
plugins/modules/packaging/os/apk.py Outdated Show resolved Hide resolved
plugins/modules/packaging/os/apk.py Outdated Show resolved Hide resolved
plugins/modules/packaging/os/apk.py Outdated Show resolved Hide resolved
changelogs/fragments/548_apk.yml Outdated Show resolved Hide resolved
@ansibullbot
Copy link
Collaborator

@aminvakil This PR contains @ mentions in at least one commit message. Those mentions can cause cascading notifications through GitHub and need to be removed. Please squash or amend your commits to remove the mentions.

click here for bot help

@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR community_review and removed community_review needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jun 21, 2020
@felixfontein
Copy link
Collaborator

Ah, unfortunately now you have to rebase this PR after #554 got merged.

@ansibullbot ansibullbot added needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed community_review needs_triage new_contributor Help guide this first time contributor labels Jun 22, 2020
@ansibullbot
Copy link
Collaborator

@aminvakil this PR contains the following merge commits:

Please rebase your branch to remove these commits.

click here for bot help

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Jun 22, 2020
@ansibullbot ansibullbot added the merge_commit This PR contains at least one merge commit. Please resolve! label Jun 22, 2020
@aminvakil aminvakil closed this Jun 22, 2020
@aminvakil aminvakil reopened this Jun 22, 2020
@aminvakil
Copy link
Contributor Author

The rebase wasn't successful and I removed all commits for this PR by mistake, edited this again, could you please review it once again in case I haven't missed something?

@ansibullbot ansibullbot added community_review and removed merge_commit This PR contains at least one merge commit. Please resolve! needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html labels Jun 22, 2020
@felixfontein felixfontein merged commit 7e17b55 into ansible-collections:master Jun 23, 2020
@felixfontein
Copy link
Collaborator

@aminvakil thanks for implementing this!

@tdtrask
Copy link

tdtrask commented Jun 24, 2020

@aminvakil Thanks for your contribution, and @felixfontein Thanks for your review. You worked so fast I never even had a chance to review the change. :)

@felixfontein
Copy link
Collaborator

@tdtrask this one looked safe enough ;) Please still take a look whether it looks good to you :)

@tdtrask
Copy link

tdtrask commented Jun 24, 2020

@felixfontein I looked, and it's all good. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein Awaiting requested review from felixfontein

Assignees
No one assigned
Labels
community_review feature This issue/PR relates to a feature request has_issue module module os packaging plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aminvakil @ansibullbot @felixfontein @tdtrask