snap_alias: using CmdRunner #5486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
felixfontein
approved these changes
Nov 7, 2022
felixfontein
added
the
check-before-release
felixfontein
reviewed
Nov 7, 2022
ansibullbot
added
the
needs_revision
ansibullbot
added
needs_ci
This comment was marked as resolved.
This comment was marked as resolved.
ansibullbot
removed
the
needs_ci
russoz
force-pushed
the
snap-alias-cmd-runner
branch
from
f0752ff
to
71e3782
Compare
russoz
force-pushed
the
snap-alias-cmd-runner
branch
from
fa40676
to
b460a65
Compare
ansibullbot
removed
WIP
felixfontein
approved these changes
Jan 7, 2023
felixfontein
approved these changes
Jan 8, 2023
felixfontein
removed
the
check-before-release
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5801 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jan 8, 2023
* snap_alias: using CmdRunner * add changelog fragment * fix changelog fragment * invert order of initialization in __init_module__() * comment extra changed=True from code * add extra info when verbose * add extra info when verbose - fix blank line * handle check_mode the old way * fix logical test * fix error when using multiple aliases * fix error when using multiple aliases, part 2 * revert to using check_mode_skip=True again (cherry picked from commit 4caa657)
|
@russoz thanks! |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
felixfontein
pushed a commit
that referenced
this pull request
Jan 8, 2023
…5801) snap_alias: using CmdRunner (#5486) * snap_alias: using CmdRunner * add changelog fragment * fix changelog fragment * invert order of initialization in __init_module__() * comment extra changed=True from code * add extra info when verbose * add extra info when verbose - fix blank line * handle check_mode the old way * fix logical test * fix error when using multiple aliases * fix error when using multiple aliases, part 2 * revert to using check_mode_skip=True again (cherry picked from commit 4caa657) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
felixfontein
pushed a commit
to felixfontein/community.general
that referenced
this pull request
Feb 20, 2023
… using CmdRunner (ansible-collections#5801) snap_alias: using CmdRunner (ansible-collections#5486) * snap_alias: using CmdRunner * add changelog fragment * fix changelog fragment * invert order of initialization in __init_module__() * comment extra changed=True from code * add extra info when verbose * add extra info when verbose - fix blank line * handle check_mode the old way * fix logical test * fix error when using multiple aliases * fix error when using multiple aliases, part 2 * revert to using check_mode_skip=True again (cherry picked from commit 4caa657) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
snap_alias now using
CmdRunnerinstead ofCmdModuleHelperISSUE TYPE
COMPONENT NAME
plugins/modules/snap_alias.py