-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Duplicate vmid in proxmox_disk module #5492 #5493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Could you please add a changelog fragment? Thanks.
I have tested right now both versions (original and patched) and both work without complaints.
|
Have to mention this: such a construction is being used multiple times in proxmox modules. So I think that it will be sane to check this modules and their functions that use |
@castorsky should this be merged then? There will be a 6.0.1 release tomorrow, so this PR could make it in there. |
Sure. I think there will be no degrade after merge as it works for me and Doc-Tiebeau. |
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5536 🤖 @patchback |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5537 🤖 @patchback |
@Doc-Tiebeau thanks for your contribution! |
Oh, I merged this a bit too quickly, there's no changelog fragment... I'll add one in a follow-up commit... |
#5492
SUMMARY
Remove duplicated vmid reference in URI builder.
Fixes #5492
ISSUE TYPE
BUG: Resize disk blocking feature