Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xfconf: prune deprecated facts-generation code #5502

Merged
merged 4 commits into from Nov 10, 2022
Merged

xfconf: prune deprecated facts-generation code #5502

merged 4 commits into from Nov 10, 2022

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Nov 8, 2022

SUMMARY

Pruning unused function, plus two variables were still marked as facts.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/xfconf.py

@ansibullbot
Copy link
Collaborator

cc @jbenden
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module plugins plugin (any type) system labels Nov 8, 2022
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 8, 2022
@felixfontein felixfontein added the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 8, 2022
@felixfontein felixfontein added the breaking_change This PR contains a breaking change that MUST NOT be backported label Nov 9, 2022
@github-actions

This comment was marked as off-topic.

Sign in to view
@russoz @felixfontein
Update changelogs/fragments/5502-xfconf-facts-deprecation.yml
3c29d2d 
Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein merged commit bc0f993 into ansible-collections:main Nov 10, 2022
@felixfontein
Copy link
Collaborator

@russoz thanks for fixing this!

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 10, 2022
@russoz russoz deleted the xfconf-enforce-facts-deprecation branch November 10, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
breaking_change This PR contains a breaking change that MUST NOT be backported bug This issue/PR relates to a bug module module plugins plugin (any type) system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@russoz @ansibullbot @felixfontein