pkgng: Add stdout and stderr to response object #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To ease debugging if something goes wrong during pkg run.
ansibullbot
added
affects_2.10
community_review
feature
Fix crash when run with "autoremove: yes" but no packages need to be autoremoved.
|
You need a changelog fragment. |
|
Thanks @felixfontein - added a changelog fragment. |
…stderr.yaml Co-authored-by: Felix Fontein <felix@fontein.de>
There aren't really any automated tests for this module at present. I manually tested package installs (state: present), upgrades (state: latest with an older package installed), uninstalls (state: absent) and autoremove. They all work as expected. |
felixfontein
approved these changes
Jun 23, 2020
|
@dsg22 thanks for implementing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ease debugging if something goes wrong during pkg run.
SUMMARY
Expose the stdout and stderr of pkg through the result object of the pkgng module. Currently, if something goes wrong during the pkg run, the user has no way to see what happened, which makes recovering from that situation more difficult.
ISSUE TYPE
COMPONENT NAME
pkgng
ADDITIONAL INFORMATION