Remove automatically adding # symbol to channel names #5629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
There was a problem hiding this comment.
Thanks for your contribution! Could you please add a changelog fragment? Thanks.
There was a problem hiding this comment.
Thanks for your contribution. I've added a first comment. Could you please add a changelog fragment? Thanks.
felixfontein
added
check-before-release
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
needs_revision
ansibullbot
removed
the
needs_revision
Co-authored-by: Felix Fontein <felix@fontein.de>
wmcbroomd2d
changed the title
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
changelogs/fragments/5629-add-prepend-hash-option-for-channel-id.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
…id.yml Co-authored-by: Felix Fontein <felix@fontein.de>
changelogs/fragments/5629-add-prepend-hash-option-for-channel-id.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
approved these changes
Nov 30, 2022
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5641 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
* Add regex to match all channel ids * Add changelog fragment * Allow matching of channel ids with 9-11 characters * Fix file name * Update changelogs/fragments/5629-add-channel-prefix-regex.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Remove channel auto prepend # * Update changelog fragment * Add prepend_hash option * Add version_added to prepend_hash doc string Co-authored-by: Felix Fontein <felix@fontein.de> * Add description of possible values for the prepend_hash option Co-authored-by: Felix Fontein <felix@fontein.de> * Remove old channel assign statement * Update changelogs/fragments/5629-add-prepend-hash-option-for-channel-id.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelog fragment tag Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 03039a5)
|
@wmcbroomd2d thanks for improving the module! |
felixfontein
removed
the
check-before-release
felixfontein
pushed a commit
that referenced
this pull request
Dec 1, 2022
…symbol to channel names (#5641) Remove automatically adding # symbol to channel names (#5629) * Add regex to match all channel ids * Add changelog fragment * Allow matching of channel ids with 9-11 characters * Fix file name * Update changelogs/fragments/5629-add-channel-prefix-regex.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Remove channel auto prepend # * Update changelog fragment * Add prepend_hash option * Add version_added to prepend_hash doc string Co-authored-by: Felix Fontein <felix@fontein.de> * Add description of possible values for the prepend_hash option Co-authored-by: Felix Fontein <felix@fontein.de> * Remove old channel assign statement * Update changelogs/fragments/5629-add-prepend-hash-option-for-channel-id.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update changelog fragment tag Co-authored-by: Felix Fontein <felix@fontein.de> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 03039a5) Co-authored-by: William McBroom <william.mcbroom@draft2digital.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
For channels with IDs that starts with G4 a # symbol is being prepended causing it to fail.
Channel IDs can start with either C, G, or D but there is no documentation on the length of the ID so it isn't possible to be able to create logic to catch all the possible IDs without false positives from channel name values.
This change removes the logic to automatically prepend # to passed in channel value.
Fixes issue #2608
https://api.slack.com/docs/conversations-api#shared_channels
ISSUE TYPE
COMPONENT NAME
slack
ADDITIONAL INFORMATION
When trying to edit a slack message in a private channel by using the message_id argument I get an error that the channel was not found with the Channel ID
G4xxxxxxxbuild_payload_for_slackis called there is an if which prepends # if channel_id does not starts with a certain symbols or does not have one of the listed two character prefixes. I've stumbled upon a channel which ID starts with G4 but current implementation doesn't have this string in the list so I got #G4xxxxxx added to payload.G4xxxxxxxwhich is returned by previous task run.