Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo disable_looups in inventory/proxmox #5640

Merged

Conversation

tbjers
Copy link
Contributor

@tbjers tbjers commented Dec 1, 2022

SUMMARY

Resolve issue with lookups in proxmox inventory config.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

proxmox

ADDITIONAL INFORMATION
$ ansible-inventory -i my.proxmox.yml --graph
[WARNING]:  * Failed to parse /home/ansible/infrastructure/my.proxmox.yml with auto plugin: template() got an unexpected keyword argument 'disable_looups'
[WARNING]:  * Failed to parse /home/ansible/infrastructure/my.proxmox.yml with yaml plugin: Plugin configuration YAML file, not YAML inventory
[WARNING]:  * Failed to parse /home/ansible/infrastructure/my.proxmox.yml with ini plugin: Invalid host pattern '---' supplied, '---' is normally a sign this is a YAML file.
[WARNING]:  * Failed to parse /home/ansible/infrastructure/my.proxmox.yml with ansible_collections.community.general.plugins.inventory.proxmox plugin: template() got an unexpected keyword argument
'disable_looups'
[WARNING]: Unable to parse /home/ansible/infrastructure/my.proxmox.yml as an inventory source
[WARNING]: No inventory was parsed, only implicit localhost is available
@all:
  |--@ungrouped:

Once typo is fixed, it correctly lists hosts.

- resolve issue with lookups in proxmox inventory config
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you please add a changelog fragment? Thanks!

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug inventory inventory plugin new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Dec 1, 2022
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 and removed small_patch Hopefully easy to review plugins plugin (any type) labels Dec 1, 2022
@ansibullbot ansibullbot added the small_patch Hopefully easy to review label Dec 1, 2022
@github-actions
Copy link

github-actions bot commented Dec 1, 2022

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed small_patch Hopefully easy to review labels Dec 1, 2022
@ansibullbot ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 1, 2022
@felixfontein felixfontein merged commit fd436bd into ansible-collections:main Dec 2, 2022
@patchback
Copy link

patchback bot commented Dec 2, 2022

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply fd436bd on top of patchback/backports/stable-5/fd436bdbc2917365580851a9a0cf940875633ea1/pr-5640

Backporting merged PR #5640 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/stable-5/fd436bdbc2917365580851a9a0cf940875633ea1/pr-5640 upstream/stable-5
  4. Now, cherry-pick PR fix typo disable_looups in inventory/proxmox #5640 contents into that branch:
    $ git cherry-pick -x fd436bdbc2917365580851a9a0cf940875633ea1
    If it'll yell at you with something like fatal: Commit fd436bdbc2917365580851a9a0cf940875633ea1 is a merge but no -m option was given., add -m 1 as follows intead:
    $ git cherry-pick -m1 -x fd436bdbc2917365580851a9a0cf940875633ea1
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR fix typo disable_looups in inventory/proxmox #5640 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/stable-5/fd436bdbc2917365580851a9a0cf940875633ea1/pr-5640
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 2, 2022
@patchback
Copy link

patchback bot commented Dec 2, 2022

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/fd436bdbc2917365580851a9a0cf940875633ea1/pr-5640

Backported as #5644

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@tbjers thanks for fixing this!

patchback bot pushed a commit that referenced this pull request Dec 2, 2022
* fix typo disable_looups in inventory/proxmox

- resolve issue with lookups in proxmox inventory config

* add changelog fragment

* Update changelogs/fragments/5640-fix-typo-proxmox-inventory.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit fd436bd)
felixfontein pushed a commit that referenced this pull request Dec 2, 2022
…entory/proxmox (#5644)

fix typo disable_looups in inventory/proxmox (#5640)

* fix typo disable_looups in inventory/proxmox

- resolve issue with lookups in proxmox inventory config

* add changelog fragment

* Update changelogs/fragments/5640-fix-typo-proxmox-inventory.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit fd436bd)

Co-authored-by: Torgny Bjers <torgny@bjers.org>
@tbjers
Copy link
Contributor Author

tbjers commented Dec 2, 2022

@tbjers thanks for fixing this!

Thank you so much for merging so quickly!

@tbjers tbjers deleted the fix/proxmox-inventory-typo branch December 2, 2022 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug inventory inventory plugin new_contributor Help guide this first time contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants