Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consul: deprecate params incompatible with state=absent #5772

Merged
merged 6 commits into from
Jan 13, 2023
Merged

consul: deprecate params incompatible with state=absent #5772

merged 6 commits into from
Jan 13, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Jan 7, 2023

SUMMARY

Deprecate using parameters unused for state=absent.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

plugins/modules/consul.py

@ansibullbot
Copy link
Collaborator

cc @sgargan
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug clustering module module plugins plugin (any type) labels Jan 7, 2023
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 7, 2023
@github-actions
Copy link

github-actions bot commented Jan 7, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

russoz
russoz commented Jan 7, 2023
View reviewed changes
plugins/modules/consul.py Outdated Show resolved Hide resolved
felixfontein
felixfontein reviewed Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I'm wondering: why do you want to force the user not to specify these parameters when state=absent?

changelogs/fragments/5772-consul-deprecate-params-when-absent.yml Outdated Show resolved Hide resolved
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Jan 12, 2023
@russoz @felixfontein
Update changelogs/fragments/5772-consul-deprecate-params-when-absent.yml
dfddcb2 
Co-authored-by: Felix Fontein <felix@fontein.de>
@russoz
Copy link
Collaborator Author

russoz commented Jan 12, 2023

One thing I'm wondering: why do you want to force the user not to specify these parameters when state=absent?

Because that is holding back implementing a required_if and a mutually_exclusive - see the long comment in the code about what to do when removing in c.g. 8.0.0

@felixfontein felixfontein merged commit cc79c24 into ansible-collections:main Jan 13, 2023
@patchback
Copy link

patchback bot commented Jan 13, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/cc79c24c01010ed75b2dee116ddf36276ffd2763/pr-5772

Backported as #5831

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 13, 2023
@felixfontein
Copy link
Collaborator

@russoz thanks!

patchback bot pushed a commit that referenced this pull request Jan 13, 2023
@russoz @patchback
consul: deprecate params incompatible with state=absent (#5772)
ff3d399 
* consul: deprecate params incompatible with state=absent

* Refrain from handling SystemExit exception

* preposition

* add changelog fragment

* Update plugins/modules/consul.py

* Update changelogs/fragments/5772-consul-deprecate-params-when-absent.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit cc79c24)
@patchback patchback bot mentioned this pull request Jan 13, 2023
Merged
felixfontein pushed a commit that referenced this pull request Jan 13, 2023
@patchback @russoz
[PR #5772/cc79c24c backport][stable-6] consul: deprecate params incom…
474364c 
…patible with state=absent (#5831)

consul: deprecate params incompatible with state=absent (#5772)

* consul: deprecate params incompatible with state=absent

* Refrain from handling SystemExit exception

* preposition

* add changelog fragment

* Update plugins/modules/consul.py

* Update changelogs/fragments/5772-consul-deprecate-params-when-absent.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit cc79c24)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the consul-deprecate-params branch January 13, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug clustering module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@russoz @ansibullbot @felixfontein