Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xml children module parameter does not exist #5808

Merged
merged 5 commits into from Jan 14, 2023
Merged

xml children module parameter does not exist #5808

merged 5 commits into from Jan 14, 2023

Conversation

Warkdev
Copy link
Contributor

@Warkdev Warkdev commented Jan 9, 2023

SUMMARY

Fixes #4166

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

xml

@Warkdev
Copy link
Contributor Author

Warkdev commented Jan 9, 2023 •
edited

Issue reporter: @jooola

@ansibullbot
Copy link
Collaborator

cc @cmprescott @dagwieers @sm4rk0 @tbielawa
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug files integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests labels Jan 9, 2023
@github-actions
Copy link

github-actions bot commented Jan 9, 2023 •
edited

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@Warkdev Warkdev changed the title [WIP] xml children module parameter does not exist xml children module parameter does not exist Jan 9, 2023
@ansibullbot ansibullbot removed the WIP Work in progress label Jan 9, 2023
russoz
russoz approved these changes Jan 9, 2023
View reviewed changes
Copy link
Collaborator

@russoz russoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 backport-6 Automatically create a backport for the stable-6 branch labels Jan 12, 2023
felixfontein
felixfontein reviewed Jan 12, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

changelogs/fragments/5808-xml-children-parameter-does-not-exist.yml Outdated Show resolved Hide resolved
@Warkdev @felixfontein
Update changelogs/fragments/5808-xml-children-parameter-does-not-exis…
17ff9ec 
…t.yml

Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein felixfontein merged commit 6ec0497 into ansible-collections:main Jan 14, 2023
@patchback
Copy link

patchback bot commented Jan 14, 2023 •
edited

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/6ec049734e4b54edcf8dffbad64bf777fc9701e6/pr-5808

Backported as #5838

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 14, 2023
patchback bot pushed a commit that referenced this pull request Jan 14, 2023
@Warkdev @patchback
xml children module parameter does not exist (#5808)
96da3c0 
* Add changelog

* Add integration tests

* Rename children to set_children

* Add PR information

* Update changelogs/fragments/5808-xml-children-parameter-does-not-exist.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 6ec0497)
@patchback patchback bot mentioned this pull request Jan 14, 2023
Merged
@patchback
Copy link

patchback bot commented Jan 14, 2023 •
edited

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/6ec049734e4b54edcf8dffbad64bf777fc9701e6/pr-5808

Backported as #5839

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@Warkdev thanks for your contribution!
@russoz thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Jan 14, 2023
@Warkdev @patchback
xml children module parameter does not exist (#5808)
1e7c669 
* Add changelog

* Add integration tests

* Rename children to set_children

* Add PR information

* Update changelogs/fragments/5808-xml-children-parameter-does-not-exist.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 6ec0497)
@patchback patchback bot mentioned this pull request Jan 14, 2023
Merged
felixfontein pushed a commit that referenced this pull request Jan 14, 2023
@patchback @Warkdev
[PR #5808/6ec04973 backport][stable-5] xml children module parameter …
2a2bfb6 
…does not exist (#5838)

xml children module parameter does not exist (#5808)

* Add changelog

* Add integration tests

* Rename children to set_children

* Add PR information

* Update changelogs/fragments/5808-xml-children-parameter-does-not-exist.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 6ec0497)

Co-authored-by: Cédric Servais <cedric.servais@outlook.com>
felixfontein pushed a commit that referenced this pull request Jan 14, 2023
@patchback @Warkdev
[PR #5808/6ec04973 backport][stable-6] xml children module parameter …
c0fde76 
…does not exist (#5839)

xml children module parameter does not exist (#5808)

* Add changelog

* Add integration tests

* Rename children to set_children

* Add PR information

* Update changelogs/fragments/5808-xml-children-parameter-does-not-exist.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 6ec0497)

Co-authored-by: Cédric Servais <cedric.servais@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@russoz russoz russoz approved these changes

Assignees
No one assigned
Labels
backport-6 Automatically create a backport for the stable-6 branch bug This issue/PR relates to a bug files integration tests/integration module module new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

xml.children parameter in documentation examples does not exist
4 participants
@Warkdev @ansibullbot @felixfontein @russoz