-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gitlab_deploy_key.py #5888
Update gitlab_deploy_key.py #5888
Conversation
Change key title on key update
Add changelog fragment for key title change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the changelog comment, LGTM.
Upstream docs- https://docs.gitlab.com/ee/api/deploy_keys.html#update-deploy-key
Co-authored-by: Felix Fontein <felix@fontein.de>
I didn't spot on the first go that the filename of the changelog fragment is missing a |
This comment was marked as outdated.
This comment was marked as outdated.
Backport to stable-5: 💚 backport PR created✅ Backport PR branch: Backported as #5895 🤖 @patchback |
* Update gitlab_deploy_key.py Change key title on key update * Create 5888-update-key-title Add changelog fragment for key title change * Update changelogs/fragments/5888-update-key-title Co-authored-by: Felix Fontein <felix@fontein.de> * Rename 5888-update-key-title to 5888-update-key-title.yml Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 855cbd6)
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #5896 🤖 @patchback |
* Update gitlab_deploy_key.py Change key title on key update * Create 5888-update-key-title Add changelog fragment for key title change * Update changelogs/fragments/5888-update-key-title Co-authored-by: Felix Fontein <felix@fontein.de> * Rename 5888-update-key-title to 5888-update-key-title.yml Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 855cbd6)
…5895) Update gitlab_deploy_key.py (#5888) * Update gitlab_deploy_key.py Change key title on key update * Create 5888-update-key-title Add changelog fragment for key title change * Update changelogs/fragments/5888-update-key-title Co-authored-by: Felix Fontein <felix@fontein.de> * Rename 5888-update-key-title to 5888-update-key-title.yml Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 855cbd6) Co-authored-by: lapete <github@lapete.de>
…5896) Update gitlab_deploy_key.py (#5888) * Update gitlab_deploy_key.py Change key title on key update * Create 5888-update-key-title Add changelog fragment for key title change * Update changelogs/fragments/5888-update-key-title Co-authored-by: Felix Fontein <felix@fontein.de> * Rename 5888-update-key-title to 5888-update-key-title.yml Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 855cbd6) Co-authored-by: lapete <github@lapete.de>
Change key title on key update
SUMMARY
The key title is not changed in gitlab even when set.
title
is required but currently ignored. This PR changes the title.ISSUE TYPE
COMPONENT NAME
gitlab_deploy_key