Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update gitlab_deploy_key.py #5888

Merged
merged 4 commits into from
Jan 25, 2023
Merged

Update gitlab_deploy_key.py #5888

merged 4 commits into from
Jan 25, 2023

Conversation

lapete
Copy link
Contributor

@lapete lapete commented Jan 25, 2023 •
edited
Loading

Change key title on key update

SUMMARY

The key title is not changed in gitlab even when set. title is required but currently ignored. This PR changes the title.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

gitlab_deploy_key

@lapete
Update gitlab_deploy_key.py
275cc62 
Change key title on key update
@lapete
Create 5888-update-key-title
037e634 
Add changelog fragment for key title change
@lapete lapete marked this pull request as ready for review January 25, 2023 09:13
@ansibullbot
Copy link
Collaborator

cc @Lunik @Shaps @dj-wasabi @lgatellier @marwatk @metanovii @nejch @scodeman @sh0shin @suukit @waheedi @zanssa
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug gitlab module module needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR new_contributor Help guide this first time contributor plugins plugin (any type) source_control labels Jan 25, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-5 and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Jan 25, 2023
@ansibullbot ansibullbot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Jan 25, 2023
nejch
nejch approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@nejch nejch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the changelog comment, LGTM.

Upstream docs- https://docs.gitlab.com/ee/api/deploy_keys.html#update-deploy-key

@lapete @felixfontein
Update changelogs/fragments/5888-update-key-title
9247ce4 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot ansibullbot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI label Jan 25, 2023
@felixfontein
Copy link
Collaborator

I didn't spot on the first go that the filename of the changelog fragment is missing a .yml or .yaml extension. That's why the tests are failing right now. With that changed, all tests should pass.

@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 25, 2023
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Jan 25, 2023
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jan 25, 2023
@felixfontein felixfontein merged commit 855cbd6 into ansible-collections:main Jan 25, 2023
@patchback
Copy link

patchback bot commented Jan 25, 2023 •
edited
Loading

Backport to stable-5: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-5/855cbd67aed46e9cae30fda61535fa21183a40bb/pr-5888

Backported as #5895

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Jan 25, 2023
Merged
patchback bot pushed a commit that referenced this pull request Jan 25, 2023
@lapete @patchback
Update gitlab_deploy_key.py (#5888)
b004a1f 
* Update gitlab_deploy_key.py

Change key title on key update

* Create 5888-update-key-title

Add changelog fragment for key title change

* Update changelogs/fragments/5888-update-key-title

Co-authored-by: Felix Fontein <felix@fontein.de>

* Rename 5888-update-key-title to 5888-update-key-title.yml

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 855cbd6)
@patchback
Copy link

patchback bot commented Jan 25, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/855cbd67aed46e9cae30fda61535fa21183a40bb/pr-5888

Backported as #5896

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@lapete thanks for your contribution!
@nejch thanks for reviewing!

patchback bot pushed a commit that referenced this pull request Jan 25, 2023
@lapete @patchback
Update gitlab_deploy_key.py (#5888)
d33f30e 
* Update gitlab_deploy_key.py

Change key title on key update

* Create 5888-update-key-title

Add changelog fragment for key title change

* Update changelogs/fragments/5888-update-key-title

Co-authored-by: Felix Fontein <felix@fontein.de>

* Rename 5888-update-key-title to 5888-update-key-title.yml

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 855cbd6)
@patchback patchback bot mentioned this pull request Jan 25, 2023
Merged
felixfontein pushed a commit that referenced this pull request Jan 26, 2023
@patchback @lapete
[PR #5888/855cbd67 backport][stable-5] Update gitlab_deploy_key.py (#…
dfac632 
…5895)

Update gitlab_deploy_key.py (#5888)

* Update gitlab_deploy_key.py

Change key title on key update

* Create 5888-update-key-title

Add changelog fragment for key title change

* Update changelogs/fragments/5888-update-key-title

Co-authored-by: Felix Fontein <felix@fontein.de>

* Rename 5888-update-key-title to 5888-update-key-title.yml

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 855cbd6)

Co-authored-by: lapete <github@lapete.de>
felixfontein pushed a commit that referenced this pull request Jan 26, 2023
@patchback @lapete
[PR #5888/855cbd67 backport][stable-6] Update gitlab_deploy_key.py (#…
a146eb3 
…5896)

Update gitlab_deploy_key.py (#5888)

* Update gitlab_deploy_key.py

Change key title on key update

* Create 5888-update-key-title

Add changelog fragment for key title change

* Update changelogs/fragments/5888-update-key-title

Co-authored-by: Felix Fontein <felix@fontein.de>

* Rename 5888-update-key-title to 5888-update-key-title.yml

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 855cbd6)

Co-authored-by: lapete <github@lapete.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

@nejch nejch nejch approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug gitlab module module new_contributor Help guide this first time contributor plugins plugin (any type) source_control
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lapete @ansibullbot @felixfontein @nejch