Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace missing default favicon with docs.ansible.com favicon #5928

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions changelogs/fragments/5928-fix-favicon-url.yml
@@ -0,0 +1,2 @@
minor_changes:
- mattermost, rocketchat, slack - replace missing default favicon with docs.ansible.com favicon (https://github.com/ansible-collections/community.general/pull/5928).
6 changes: 3 additions & 3 deletions plugins/modules/mattermost.py
Expand Up @@ -60,8 +60,8 @@
icon_url:
type: str
description:
- Url for the message sender's icon.
default: https://www.ansible.com/favicon.ico
- URL for the message sender's icon.
default: https://docs.ansible.com/favicon.ico
validate_certs:
description:
- If C(false), SSL certificates will not be validated. This should only be used
Expand Down Expand Up @@ -127,7 +127,7 @@ def main():
text=dict(type='str'),
channel=dict(type='str', default=None),
username=dict(type='str', default='Ansible'),
icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'),
icon_url=dict(type='str', default='https://docs.ansible.com/favicon.ico'),
validate_certs=dict(default=True, type='bool'),
attachments=dict(type='list', elements='dict'),
),
Expand Down
4 changes: 2 additions & 2 deletions plugins/modules/rocketchat.py
Expand Up @@ -58,7 +58,7 @@
type: str
description:
- URL for the message sender's icon.
default: "https://www.ansible.com/favicon.ico"
default: "https://docs.ansible.com/favicon.ico"
icon_emoji:
type: str
description:
Expand Down Expand Up @@ -212,7 +212,7 @@ def main():
msg=dict(type='str', required=False),
channel=dict(type='str'),
username=dict(type='str', default='Ansible'),
icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'),
icon_url=dict(type='str', default='https://docs.ansible.com/favicon.ico'),
icon_emoji=dict(type='str'),
link_names=dict(type='int', default=1, choices=[0, 1]),
validate_certs=dict(default=True, type='bool'),
Expand Down
6 changes: 3 additions & 3 deletions plugins/modules/slack.py
Expand Up @@ -81,8 +81,8 @@
icon_url:
type: str
description:
- Url for the message sender's icon (default C(https://www.ansible.com/favicon.ico))
default: https://www.ansible.com/favicon.ico
- URL for the message sender's icon (default C(https://docs.ansible.com/favicon.ico))
default: https://docs.ansible.com/favicon.ico
icon_emoji:
type: str
description:
Expand Down Expand Up @@ -439,7 +439,7 @@ def main():
channel=dict(type='str'),
thread_id=dict(type='str'),
username=dict(type='str', default='Ansible'),
icon_url=dict(type='str', default='https://www.ansible.com/favicon.ico'),
icon_url=dict(type='str', default='https://docs.ansible.com/favicon.ico'),
icon_emoji=dict(type='str'),
link_names=dict(type='int', default=1, choices=[0, 1]),
parse=dict(type='str', choices=['none', 'full']),
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/plugins/modules/test_slack.py
Expand Up @@ -142,7 +142,7 @@ def test_message_with_blocks(self):
},
'accessory': {
'type': 'image',
'image_url': 'https://www.ansible.com/favicon.ico',
'image_url': 'https://docs.ansible.com/favicon.ico',
'alt_text': 'test'
}
}, {
Expand Down