Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pylint errors #5933

Merged
merged 2 commits into from
Feb 4, 2023
Merged

Fix pylint errors #5933

merged 2 commits into from
Feb 4, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

ansible-core devel's ansible-test is using a newer pylint, which makes CI fail. This fixes the problems it exposes.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

CI

@ansibullbot
Copy link
Collaborator

cc @indrajitr @jasperla @m-yosefpor @rainerleber @tmshn
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug cloud module module plugins plugin (any type) system labels Feb 3, 2023
@ansibullbot
Copy link
Collaborator

cc @Akasurde @Lowess @jbenden @kevensen @russoz
click here for bot help

@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR net_tools labels Feb 4, 2023
@github-actions
Copy link

github-actions bot commented Feb 4, 2023 •
edited
Loading

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

kristianheljas
kristianheljas approved these changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@kristianheljas kristianheljas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@ansibullbot ansibullbot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Feb 4, 2023
mariolenz
mariolenz approved these changes Feb 4, 2023
View reviewed changes
Copy link
Contributor

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein merged commit b1d9507 into ansible-collections:main Feb 4, 2023
@felixfontein felixfontein deleted the lint branch February 4, 2023 16:05
@patchback
Copy link

patchback bot commented Feb 4, 2023 •
edited
Loading

Backport to stable-4: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply b1d9507 on top of patchback/backports/stable-4/b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f/pr-5933

Backporting merged PR #5933 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it: 
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/stable-4/b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f/pr-5933 upstream/stable-4
  4. Now, cherry-pick PR Fix pylint errors #5933 contents into that branch: 
    $ git cherry-pick -x b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f
    If it'll yell at you with something like fatal: Commit b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f is a merge but no -m option was given., add -m 1 as follows intead: 
    $ git cherry-pick -m1 -x b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix pylint errors #5933 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/stable-4/b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f/pr-5933
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link

patchback bot commented Feb 4, 2023 •
edited
Loading

Backport to stable-5: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply b1d9507 on top of patchback/backports/stable-5/b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f/pr-5933

Backporting merged PR #5933 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it: 
    $ git remote add upstream https://github.com/ansible-collections/community.general.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code: 
    $ git fetch upstream
$ git checkout -b patchback/backports/stable-5/b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f/pr-5933 upstream/stable-5
  4. Now, cherry-pick PR Fix pylint errors #5933 contents into that branch: 
    $ git cherry-pick -x b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f
    If it'll yell at you with something like fatal: Commit b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f is a merge but no -m option was given., add -m 1 as follows intead: 
    $ git cherry-pick -m1 -x b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Fix pylint errors #5933 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub: 
    $ git push origin patchback/backports/stable-5/b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f/pr-5933
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator Author

@kristianheljas @mariolenz thanks a lot for reviewing this!

@patchback
Copy link

patchback bot commented Feb 4, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/b1d9507cd2986cc2f3e9d918a56477ef2eba3d1f/pr-5933

Backported as #5937

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 4, 2023
@felixfontein @patchback
Fix pylint errors (#5933)
239d53b 
* Fix pylint errors.

* Also adjust to ansible/ansible#79909.

(cherry picked from commit b1d9507)
@patchback patchback bot mentioned this pull request Feb 4, 2023
Merged
felixfontein added a commit to felixfontein/community.general that referenced this pull request Feb 4, 2023
@felixfontein
Fix pylint errors (ansible-collections#5933)
da18ed4 
* Fix pylint errors.

* Also adjust to ansible/ansible#79909.

(cherry picked from commit b1d9507)
felixfontein added a commit to felixfontein/community.general that referenced this pull request Feb 4, 2023
@felixfontein
Fix pylint errors (ansible-collections#5933)
2b72bcd 
* Fix pylint errors.

* Also adjust to ansible/ansible#79909.

(cherry picked from commit b1d9507)
This was referenced Feb 4, 2023
Merged
Merged
@felixfontein
Copy link
Collaborator Author

@kristianheljas @mariolenz thanks a lot!

felixfontein added a commit that referenced this pull request Feb 4, 2023
@patchback @felixfontein
[PR #5933/b1d9507c backport][stable-6] Fix pylint errors (#5937)
d8cf32e 
Fix pylint errors (#5933)

* Fix pylint errors.

* Also adjust to ansible/ansible#79909.

(cherry picked from commit b1d9507)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Feb 4, 2023
@felixfontein
[stable-5] Fix pylint errors (#5938)
6932a93 
Fix pylint errors (#5933)

* Fix pylint errors.

* Also adjust to ansible/ansible#79909.

(cherry picked from commit b1d9507)
felixfontein added a commit that referenced this pull request Feb 4, 2023
@felixfontein
[stable-4] Fix pylint errors (#5939)
bbe74d2 
Fix pylint errors (#5933)

* Fix pylint errors.

* Also adjust to ansible/ansible#79909.

(cherry picked from commit b1d9507)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

@kristianheljas kristianheljas kristianheljas approved these changes

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug cloud module module net_tools plugins plugin (any type) system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibullbot @mariolenz @kristianheljas