Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #5928/a64df658 backport][stable-6] Replace missing default favicon with docs.ansible.com favicon #5935

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Feb 3, 2023

This is a backport of PR #5928 as merged into main (a64df65).

SUMMARY

The affected modules use a non-existing https://www.ansible.com/favicon.ico as default icon when creating chat messages. This change uses the icon from https://docs.ansible.com/favicon.ico instead

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • mattermost
  • rocketchat
  • slack

* replace missing default favicon with docs.ansible.com

* create changelog fragment for PR 5928

* move changelog fragment

* fix parameter description

Co-authored-by: Felix Fontein <felix@fontein.de>

* fix parameter description

Co-authored-by: Felix Fontein <felix@fontein.de>

* add affected modules in changelog fragment

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Lars Krahl <lkr@mms-dresden.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit a64df65)
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added backport bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor notification plugins plugin (any type) tests tests unit tests/unit labels Feb 3, 2023
@felixfontein felixfontein merged commit ead9524 into stable-6 Feb 3, 2023
@felixfontein felixfontein deleted the patchback/backports/stable-6/a64df658c5eb09621feffb2f6e4c6b0b14501c59/pr-5928 branch February 3, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor notification plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants