-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nmcli: add new addr_gen_mode6 options #5974
nmcli: add new addr_gen_mode6 options #5974
Conversation
Docs Build 📝Thank you for contribution!✨ The docsite for this PR is available for download as an artifact from this run: File changes:
Click to see the diff comparison.NOTE: only file modifications are shown here. New and deleted files are excluded. diff --git a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/nmcli_module.html b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/nmcli_module.html
index b4800f7..f932a75 100644
--- a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/nmcli_module.html
+++ b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/nmcli_module.html
@@ -189,6 +189,8 @@ see <a class="reference internal" href="#ansible-collections-community-general-n
<td><div class="ansible-option-cell"><p>Configure method for creating the address for use with IPv6 Stateless Address Autoconfiguration.</p>
<p class="ansible-option-line"><span class="ansible-option-choices">Choices:</span></p>
<ul class="simple">
+<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">"default"</span></code></p></li>
+<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">"default-or-eui64"</span></code></p></li>
<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">"eui64"</span></code></p></li>
<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">"stable-privacy"</span></code></p></li>
</ul>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Could you please add a changelog fragment? Thanks.
(I think this is a new feature though, not a bugfix, since the module did not claim to support these options.)
ping @jeffmcutter |
Co-authored-by: Felix Fontein <felix@fontein.de>
@jeffmcutter @heaveaxy @haddystuff there are currently multiple open PRs by you three for the nmcli module (#5974, #6106, #6105, #6107, #6108, #6148) which are waiting for reviews. Since I don't know nmcli well and am not maintaining this module, I would be glad if you could review each other's PRs. I'll gladly help with making sure that all formalities are OK and with merging, but I cannot really judge the PR changes themselves. Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking correct. NM supports both in the form that defined in code.
changelogs/fragments/5974-nmcli_add_new_addr_gen_mode6_options.yml
Outdated
Show resolved
Hide resolved
Will merge by the end of the week if nobody objects. |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6228 🤖 @patchback |
* nmcli: add new addr_gen_mode6 options * Add changelog fragment. * Update plugins/modules/nmcli.py Co-authored-by: Felix Fontein <felix@fontein.de> * Adjust documentation. --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit ed8049a)
@jeffmcutter thanks for your contribution! |
…options (#6228) nmcli: add new addr_gen_mode6 options (#5974) * nmcli: add new addr_gen_mode6 options * Add changelog fragment. * Update plugins/modules/nmcli.py Co-authored-by: Felix Fontein <felix@fontein.de> * Adjust documentation. --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit ed8049a) Co-authored-by: Jeffrey Cutter <jeffmcutter@users.noreply.github.com>
SUMMARY
Addresses:
Fixes #5973.
Add 'default' and 'default-or-eui64' to the list of valid choices for nmcli addr_gen_mode6 parameter.
ISSUE TYPE
nmcli
ADDITIONAL INFORMATION
See #5973.