Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nmcli: add new addr_gen_mode6 options #5974

Conversation

jeffmcutter
Copy link
Contributor

SUMMARY

Addresses:

Fixes #5973.

Add 'default' and 'default-or-eui64' to the list of valid choices for nmcli addr_gen_mode6 parameter.

ISSUE TYPE

nmcli

ADDITIONAL INFORMATION

See #5973.


@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module module net_tools plugins plugin (any type) tests tests unit tests/unit labels Feb 10, 2023
@github-actions
Copy link

Docs Build 📝

Thank you for contribution!✨

The docsite for this PR is available for download as an artifact from this run:
https://github.com/ansible-collections/community.general/actions/runs/4147120762

File changes:

  • M collections/community/general/nmcli_module.html
Click to see the diff comparison.

NOTE: only file modifications are shown here. New and deleted files are excluded.
See the file list and check the published docs to see those files.

diff --git a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/nmcli_module.html b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/nmcli_module.html
index b4800f7..f932a75 100644
--- a/home/runner/work/community.general/community.general/docsbuild/base/collections/community/general/nmcli_module.html
+++ b/home/runner/work/community.general/community.general/docsbuild/head/collections/community/general/nmcli_module.html
@@ -189,6 +189,8 @@ see <a class="reference internal" href="#ansible-collections-community-general-n
 <td><div class="ansible-option-cell"><p>Configure method for creating the address for use with IPv6 Stateless Address Autoconfiguration.</p>
 <p class="ansible-option-line"><span class="ansible-option-choices">Choices:</span></p>
 <ul class="simple">
+<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;default&quot;</span></code></p></li>
+<li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;default-or-eui64&quot;</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;eui64&quot;</span></code></p></li>
 <li><p><code class="ansible-option-choices-entry docutils literal notranslate"><span class="pre">&quot;stable-privacy&quot;</span></code></p></li>
 </ul>

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

(I think this is a new feature though, not a bugfix, since the module did not claim to support these options.)

plugins/modules/nmcli.py Show resolved Hide resolved
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Feb 11, 2023
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Feb 19, 2023
@felixfontein
Copy link
Collaborator

ping @jeffmcutter

@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Feb 28, 2023
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Mar 8, 2023
@felixfontein
Copy link
Collaborator

@jeffmcutter @heaveaxy @haddystuff there are currently multiple open PRs by you three for the nmcli module (#5974, #6106, #6105, #6107, #6108, #6148) which are waiting for reviews. Since I don't know nmcli well and am not maintaining this module, I would be glad if you could review each other's PRs. I'll gladly help with making sure that all formalities are OK and with merging, but I cannot really judge the PR changes themselves. Thanks :)

Copy link
Contributor

@heaveaxy heaveaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking correct. NM supports both in the form that defined in code.

@felixfontein
Copy link
Collaborator

Will merge by the end of the week if nobody objects.

@ansibullbot ansibullbot removed the stale_ci CI is older than 7 days, rerun before merging label Mar 22, 2023
@felixfontein felixfontein merged commit ed8049a into ansible-collections:main Mar 24, 2023
@patchback
Copy link

patchback bot commented Mar 24, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/ed8049a220096f8eaaa2bbdee665d40d00adfd56/pr-5974

Backported as #6228

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 24, 2023
patchback bot pushed a commit that referenced this pull request Mar 24, 2023
* nmcli: add new addr_gen_mode6 options

* Add changelog fragment.

* Update plugins/modules/nmcli.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Adjust documentation.

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit ed8049a)
@felixfontein
Copy link
Collaborator

@jeffmcutter thanks for your contribution!
@heaveaxy thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Mar 25, 2023
…options (#6228)

nmcli: add new addr_gen_mode6 options (#5974)

* nmcli: add new addr_gen_mode6 options

* Add changelog fragment.

* Update plugins/modules/nmcli.py

Co-authored-by: Felix Fontein <felix@fontein.de>

* Adjust documentation.

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit ed8049a)

Co-authored-by: Jeffrey Cutter <jeffmcutter@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug module module net_tools plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nmcli changes to addr_gen_mode6 choices in newer os versions
4 participants