Adding open option to nmap
#6200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
docs
inventory
|
Sorry, I built this off of a current PR: #6165 So this is dependent on that. Let me know if I should pull out the |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
felixfontein
added
check-before-release
barloff-st
force-pushed
the
open-options
branch
from
1cd4088
to
bf8f295
Compare
|
@barloff-st was it intentional that you closed this one (by pushing an 'empty' branch)? |
|
@felixfontein No that was not my intention. I synced my |
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
merge_commit
barloff-st
force-pushed
the
open-options
branch
from
f85c4c0
to
9f5fbe7
Compare
ansibullbot
removed
merge_commit
This comment was marked as outdated.
This comment was marked as outdated.
barloff-st
force-pushed
the
open-options
branch
from
9f5fbe7
to
56f1f14
Compare
|
@felixfontein issues with rebase have been resolved. Should be good now. |
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
ansibullbot
added
needs_ci
felixfontein
approved these changes
Mar 24, 2023
felixfontein
removed
the
check-before-release
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6246 🤖 @patchback |
|
@barloff-st thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Mar 26, 2023
* Adding nmap `open` option * Removing accidental copy/paste issue * Update changelogs/fragments/6200-adding-open-option-to-nmap.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/inventory/nmap.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 59e5807)
felixfontein
pushed a commit
that referenced
this pull request
Mar 26, 2023
…6246) Adding `open` option to nmap (#6200) * Adding nmap `open` option * Removing accidental copy/paste issue * Update changelogs/fragments/6200-adding-open-option-to-nmap.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Update plugins/inventory/nmap.py Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 59e5807) Co-authored-by: barloff-st <42866449+barloff-st@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This will add in the
--openoption for thenmapinventory plugin. Currently the port scan (-sP) just scans ports and returns results from all ports, regardless of if they are closed. Theopenoption will all for only open ports to be returned. This will also clarify this by removing the "open ports" mention in the currentportsargument.ISSUE TYPE
COMPONENT NAME
community.general.nmap--openoptionADDITIONAL INFORMATION