Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hpe thermal config and fan percent min #6208

Merged
merged 5 commits into from
Mar 25, 2023

Conversation

superky13
Copy link
Contributor

@superky13 superky13 commented Mar 19, 2023

SUMMARY

Added two additional functions that we use to retrieve ThermalConfiguration and FanPercentMinimum settings (via iLO) on our HPE Gen 10/10+ boxes.

ISSUE TYPE
  • Feature Pull Request
  • Refactoring Pull Request
COMPONENT NAME

redfish_info.py
redfish_utils.py

ADDITIONAL INFORMATION
  - name: Get HPE Thermal Config
    community.general.redfish_info:
      category: Chassis
      command: GetHPEThermalConfig
      baseuri: "{{ baseuri }}"
      username: "{{ username }}"
      password: "{{ password }}"

  - name: Get HPE Fan Percent Minimum
    community.general.redfish_info:
      category: Chassis
      command: GetHPEFanPercentMin
      baseuri: "{{ baseuri }}"
      username: "{{ username }}"
      password: "{{ password }}"


@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added feature This issue/PR relates to a feature request module module module_utils module_utils new_contributor Help guide this first time contributor plugins plugin (any type) remote_management labels Mar 19, 2023
@github-actions
Copy link

github-actions bot commented Mar 19, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Mar 19, 2023
@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Mar 19, 2023
@mraineri
Copy link
Contributor

This functionality could be exposed with a standard "Control" resource rather than going through OEM extensions. However, the "Control" model is much newer and very likely not implemented on the system you're using.

Is there a real need to override these thermal settings though? Typically the manufacturer doesn't want a customer to change these settings since they're all governed by the manager internally.

@mraineri
Copy link
Contributor

Whoops, missed the context; these are all "GET" operations to extract the data (no PATCH operations). This makes me feel much better.

@superky13
Copy link
Contributor Author

Whoops, missed the context; these are all "GET" operations to extract the data (no PATCH operations). This makes me feel much better.

Yeah. We use this simply to ensure unified configs.

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Please add a changelog fragment. Thanks.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Mar 22, 2023
@mraineri
Copy link
Contributor

Other than the changelog fragment, this looks good to me

@superky13
Copy link
Contributor Author

@ansibullbot

This comment was marked as outdated.

@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 23, 2023
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Mar 24, 2023
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Mar 25, 2023
@felixfontein felixfontein merged commit 33ccabe into ansible-collections:main Mar 25, 2023
@patchback
Copy link

patchback bot commented Mar 25, 2023

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/33ccabed1341f8e0a425696aa6e91a5b915bafed/pr-6208

Backported as #6237

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Mar 25, 2023
* added hpe thermal config and fan percent min

* typo fixed

* Create 6208-hpe-thermal-fan-percent.yaml

* fixed changelog fragment

* Update 6208-hpe-thermal-fan-percent.yaml

(cherry picked from commit 33ccabe)
@felixfontein
Copy link
Collaborator

@superky13 thanks for your contribution!
@mraineri thanks for reviewing!

felixfontein pushed a commit that referenced this pull request Mar 25, 2023
…an percent min (#6237)

added hpe thermal config and fan percent min (#6208)

* added hpe thermal config and fan percent min

* typo fixed

* Create 6208-hpe-thermal-fan-percent.yaml

* fixed changelog fragment

* Update 6208-hpe-thermal-fan-percent.yaml

(cherry picked from commit 33ccabe)

Co-authored-by: ky13 <k.william.ritchie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue/PR relates to a feature request module_utils module_utils module module new_contributor Help guide this first time contributor plugins plugin (any type) remote_management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants