Add support to topics on Gitlab Project module #6278

tanganellilore · 2023-04-03T13:36:03Z

SUMMARY

Team,
I added a support for topics in gitlab_project.py .

To be retrocompatible with old gitlab versione ( prior 14) I also added a check on the gitlab server and if it's less than 14 I replace topics with tag_list.

Fixes: #6277

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

gitlab_project

ADDITIONAL INFORMATION

ansibullbot · 2023-04-03T13:37:11Z

cc @Lunik @Shaps @dj-wasabi @lgatellier @marwatk @metanovii @nejch @scodeman @sh0shin @suukit @waheedi @zanssa
click here for bot help

ansibullbot · 2023-04-03T13:44:09Z

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

plugins/modules/gitlab_project.py:388:0: trailing-whitespace: Trailing whitespace
plugins/modules/gitlab_project.py:389:98: trailing-whitespace: Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/gitlab_project.py:388:1: W293: blank line contains whitespace
plugins/modules/gitlab_project.py:389:99: W291: trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/gitlab_project.py:388:1: W293: blank line contains whitespace
plugins/modules/gitlab_project.py:389:99: W291: trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/gitlab_project.py:388:1: W293: blank line contains whitespace
plugins/modules/gitlab_project.py:389:99: W291: trailing whitespace

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

plugins/modules/gitlab_project.py:388:0: trailing-whitespace: Trailing whitespace
plugins/modules/gitlab_project.py:389:98: trailing-whitespace: Trailing whitespace

The test ansible-test sanity --test pep8 [explain] failed with 2 errors:

plugins/modules/gitlab_project.py:388:1: W293: blank line contains whitespace
plugins/modules/gitlab_project.py:389:99: W291: trailing whitespace

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

plugins/modules/gitlab_project.py:388:0: trailing-whitespace: Trailing whitespace
plugins/modules/gitlab_project.py:389:98: trailing-whitespace: Trailing whitespace

The test ansible-test sanity --test pylint [explain] failed with 2 errors:

plugins/modules/gitlab_project.py:388:0: trailing-whitespace: Trailing whitespace
plugins/modules/gitlab_project.py:389:98: trailing-whitespace: Trailing whitespace

click here for bot help

github-actions · 2023-04-03T14:03:45Z

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and your docs changes will be incorporated when they are next published.

felixfontein

Thanks for your contribution! I've added some first comments.

changelogs/fragments/6277-add-topics-gitlab-project.yml

plugins/modules/gitlab_project.py

Co-authored-by: Felix Fontein <felix@fontein.de>

tanganellilore · 2023-04-03T19:28:46Z

Thanks @felixfontein, it makes sense to me and I merged your suggestions.

nejch

LGTM!

(Although I personally wouldn't bother supporting tag_list from GitLab 13, if people are running gitlab 13.x they'll have bigger problems than a missing attribute 😄)

patchback · 2023-04-03T20:02:24Z

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/cee5f31b70bff5e874ac6083c708c27c112e2bea/pr-6278

Backported as #6283

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

* add topics to gitlab_project.py * add chngelog fragment * fix lint error * Update changelogs/fragments/6277-add-topics-gitlab-project.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit cee5f31)

felixfontein · 2023-04-03T20:02:50Z

@tanganellilore thanks for implementing this!
@nejch thanks for reviewing!

…b Project module (#6283) Add support to topics on Gitlab Project module (#6278) * add topics to gitlab_project.py * add chngelog fragment * fix lint error * Update changelogs/fragments/6277-add-topics-gitlab-project.yml Co-authored-by: Felix Fontein <felix@fontein.de> * Apply suggestions from code review Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit cee5f31) Co-authored-by: Lorenzo Tanganelli <35271287+tanganellilore@users.noreply.github.com>

v7.5.0 Minor Changes ------------- ansible.posix ~~~~~~~~~~~~~ - Add jsonl callback plugin to ansible.posix collection - firewalld - add `protocol` parameter cisco.aci ~~~~~~~~~ - Add aci_access_span_dst_group module for fabric access policies span destination group support - Add aci_access_span_filter_group and aci_access_span_filter_group_entry modules for access span filter group support - Add aci_config_export_policy module - Add aci_igmp_interface_policy module - Add aci_interface_config module for new interface configuration available in ACI v5.2(5)+ - Add aci_interface_policy_spanning_tree module cisco.dnac ~~~~~~~~~~ - accesspoint_configuration_details_by_task_id_info - new module - authentication_policy_servers_info - new module - credential_to_site_by_siteid_create_v2 - new module - device_interface_info - attributes `lastInputTime` and `lastOutputTime` were added. - device_reboot_apreboot_info - new module - dnac_packages_info - new module - eox_status_device_info - new module - eox_status_summary_info - new module - event_email_config - new module - event_email_config_info - new module - event_snmp_config_info - new module - event_syslog_config - new module - event_syslog_config_info - new module - execute_suggested_actions_commands - new module - global_credential_v2 - new module - global_credential_v2_info - new module - integration_settings_instances_itsm - new module - integration_settings_instances_itsm_info - new module - lan_automation_log_by_serial_number_info - new module - network_device_user_defined_field - new module - network_device_user_defined_field_info - new module - network_v2 - new module - network_v2_info - new module - pnp_device_claim_to_site - attributes `removeInactive` and `hostname` were removed. - role_permissions_info - new module - roles_info - new module - sda_fabric_border_device - attributes `routeDistributionProtocol` and `borderPriority` were added. - sda_fabric_control_plane_device attribute `routeDistributionProtocol` was added. - sda_fabric_edge_device - attribute `siteNameHierarchy` was added. - sda_fabric_site - attribute `fabricType` was added. - sda_port_assignment_for_user_device - attribute `interfaceNames` was added. - sda_virtual_network - attribute `vManageVpnId` was added. - sda_virtual_network_ip_pool - attribute `isBridgeModeVm` was added. - sda_virtual_network_v2 - attribute `isBridgeModeVm` was added. - service_provider_v2 - new module - service_provider_v2_info - new module - sp_profile_delete_v2 - new module - user - new module - user_info - new module - users_external_servers_info - new module - wireless_accespoint_configuration - new module - wireless_accesspoint_configuration_summary_info - new module cisco.ios ~~~~~~~~~ - ios_bgp_address_family - add option redistribute.ospf.include_connected when redistributing OSPF in IPv6 AFI - ios_bgp_address_family - add option redistribute.ospf.match.externals.type_1 to allow - ios_bgp_address_family - add option redistribute.ospf.match.externals.type_2 to allow - specification of OSPF E1 routes - specification of OSPF E2 routes cisco.mso ~~~~~~~~~ - Add ip_data_plane_learning and preferred_group arguments to mso_schema_template_vrf module - Add module mso_schema_site_anp_epg_bulk_staticport - Add route_reachability attribute to mso_schema_site_external_epg module cisco.nxos ~~~~~~~~~~ - `nxos_route_maps` - add support for 'set ip next-hop <>' command in route-maps - `nxos_vxlan_vtep` - add support for 'advertise virtual-rmac' command under nve interface community.crypto ~~~~~~~~~~~~~~~~ - get_certificate - add ``asn1_base64`` option to control whether the ASN.1 included in the ``extensions`` return value is binary data or Base64 encoded (ansible-collections/community.crypto#592). community.general ~~~~~~~~~~~~~~~~~ - cpanm - minor change, use feature from ``ModuleHelper`` (ansible-collections/community.general#6385). - dconf - be forgiving about boolean values: convert them to GVariant booleans automatically (ansible-collections/community.general#6206). - dconf - minor refactoring improving parameters and dependencies validation (ansible-collections/community.general#6336). - deps module utils - add function ``failed()`` providing the ability to check the dependency check result without triggering an exception (ansible-collections/community.general#6383). - dig lookup plugin - Support multiple domains to be queried as indicated in docs (ansible-collections/community.general#6334). - gitlab_project - add new option ``topics`` for adding topics to GitLab projects (ansible-collections/community.general#6278). - homebrew_cask - allows passing ``--greedy`` option to ``upgrade_all`` (ansible-collections/community.general#6267). - idrac_redfish_command - add ``job_id`` to ``CreateBiosConfigJob`` response (ansible-collections/community.general#5603). - ipa_hostgroup - add ``append`` parameter for adding a new hosts to existing hostgroups without changing existing hostgroup members (ansible-collections/community.general#6203). - keycloak_authentication - add flow type option to sub flows to allow the creation of 'form-flow' sub flows like in Keycloak's built-in registration flow (ansible-collections/community.general#6318). - mksysb - improved the output of the module in case of errors (ansible-collections/community.general#6263). - nmap inventory plugin - added environment variables for configure ``address`` and ``exclude`` (ansible-collections/community.general#6351). - nmcli - add ``macvlan`` connection type (ansible-collections/community.general#6312). - pipx - add ``system_site_packages`` parameter to give application access to system-wide packages (ansible-collections/community.general#6308). - pipx - ensure ``include_injected`` parameter works with ``state=upgrade`` and ``state=latest`` (ansible-collections/community.general#6212). - puppet - add new options ``skip_tags`` to exclude certain tagged resources during a puppet agent or apply (ansible-collections/community.general#6293). - terraform - remove state file check condition and error block, because in the native implementation of terraform will not cause errors due to the non-existent file (ansible-collections/community.general#6296). - udm_dns_record - minor refactor to the code (ansible-collections/community.general#6382). community.zabbix ~~~~~~~~~~~~~~~~ - httpapi plugin - updated to work with Zabbix 6.4. - zabbix_action, zabbix_authentication, zabbix_discovery_rule, zabbix_mediatype, zabbix_user, zabbix_user_directory, zabbix_usergroup - updated to work with Zabbix 6.4. - zabbix_agent role - Add support for SUSE Linux Enterprise Server for SAP Applications ("SLES_SAP"). - zabbix_host - add missing variants for SNMPv3 authprotocol and privprotocol introduced by Zabbix 6 - zabbix_proxy role - Add variable zabbix_proxy_dbpassword_hash_method to control whether you want postgresql user password to be hashed with md5 or want to use db default. When zabbix_proxy_dbpassword_hash_method is set to anything other than md5 then do not hash the password with md5 so you could use postgresql scram-sha-256 hashing method. - zabbix_server role - Add variable zabbix_server_dbpassword_hash_method to control whether you want postgresql user password to be hashed with md5 or want to use db default. When zabbix_server_dbpassword_hash_method is set to anything other than md5 then do not hash the password with md5 so you could use postgresql scram-sha-256 hashing method. - zabbix_usergroup module - userdirectory, hostgroup_rights and templategroup_rights parameters added (Zabbix >= 6.2) - zabbix_web role - possibility to add custom includes in apache vhost config dellemc.powerflex ~~~~~~~~~~~~~~~~~ - Info module is enhanced to support the listing of replication pairs. dellemc.unity ~~~~~~~~~~~~~ - Add synchronous replication support for filesystem. - Support addition of host from the Host List to NFS Export in nfs module. - Support enable/disable advanced dedup in volume module. hetzner.hcloud ~~~~~~~~~~~~~~ - hcloud_image_info - Add cpu architecture field to return value. - hcloud_image_info - Allow filtering images by cpu architecture. - hcloud_server - Select matching image for the cpu architecture of the server type on create & rebuild. - hcloud_server_type_info - Add cpu architecture field to return value. - inventory plugin - Add cpu architecture to server variables. netapp.ontap ~~~~~~~~~~~~ - na_ontap_cifs - new options ``browsable`` and ``show_previous_versions`` added in REST. - na_ontap_cifs - removed default value for ``unix_symlink`` as its not supported with ZAPI. - na_ontap_cifs - updated documentation and examples for REST. - na_ontap_file_security_permissions - updated module examples. - na_ontap_ipspace - improved module fail error message in REST. - na_ontap_rest_info - improved documentation for ``parameters`` option. - na_ontap_security_config - updated documentation for ``supported_cipher_suites``. - na_ontap_user - option ``vserver`` is not required with REST, ignore this option to create cluster scoped user. netbox.netbox ~~~~~~~~~~~~~ - netbox_aggregate - Add tenant as parameter to module - netbox_asn - Add module - netbox_fhrp_group - Add module - netbox_journal_entry - Add module purestorage.flashblade ~~~~~~~~~~~~~~~~~~~~~~ - purefb_info - Added `encryption` and `support_keys` information. - purefb_info - Added bucket quota and safemode information per bucket - purefb_info - Added security update version for Purity//FB 4.0.2, or higher - purefb_info - Updated object store account information - purefb_inventory - Added `part_number` to hardware item information. - purefb_policy - Added support for multiple rules in snapshot policies - purefb_proxy - Added new boolean parameter `secure`. Default of true (for backwards compatability) sets the protocol to be `https://`. False sets `http://` - purefb_s3acc - Added support for default bucket quotas and hard limits - purefb_s3acc - Added support for object account quota and hard limit purestorage.fusion ~~~~~~~~~~~~~~~~~~ - added Python package dependency checks in prerequisites.py - fusion_hap - added missing 'windows' personality type theforeman.foreman ~~~~~~~~~~~~~~~~~~ - content_export_library, content_export_repository, content_export_version - add ``format`` option to control the export format - content_view_filter - add support for creating modulemd filters - content_view_publish role - also accept a list of dicts as the ``content_views`` role for publishing (theforeman/foreman-ansible-modules#1436) - setting - document how to obtain valid setting names (https://bugzilla.redhat.com/show_bug.cgi?id=2174367) Deprecated Features ------------------- cisco.ios ~~~~~~~~~ - ios_bgp_address_family - deprecate redistribute.ospf.match.external with redistribute.ospf.match.externals which enables attributes for OSPF type E1 and E2 routes - ios_bgp_address_family - deprecate redistribute.ospf.match.nssa_external with redistribute.ospf.match.nssa_externals which enables attributes for OSPF type N1 and N2 routes - ios_bgp_address_family - deprecate redistribute.ospf.match.type_1 with redistribute.ospf.match.nssa_externals.type_1 - ios_bgp_address_family - deprecate redistribute.ospf.match.type_2 with redistribute.ospf.match.nssa_externals.type_2

tanganellilore added 2 commits April 3, 2023 15:21

add topics to gitlab_project.py

421cc33

add chngelog fragment

4f3936e

ansibullbot added feature This issue/PR relates to a feature request gitlab module module new_contributor Help guide this first time contributor plugins plugin (any type) source_control labels Apr 3, 2023

ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 3, 2023

fix lint error

51937fd

ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 3, 2023

felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 labels Apr 3, 2023

felixfontein reviewed Apr 3, 2023

View reviewed changes

tanganellilore and others added 2 commits April 3, 2023 21:24

Update changelogs/fragments/6277-add-topics-gitlab-project.yml

bf9cd8e

Co-authored-by: Felix Fontein <felix@fontein.de>

Apply suggestions from code review

d3cebfa

Co-authored-by: Felix Fontein <felix@fontein.de>

ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Apr 3, 2023

ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Apr 3, 2023

nejch approved these changes Apr 3, 2023

View reviewed changes

felixfontein merged commit cee5f31 into ansible-collections:main Apr 3, 2023

patchback bot mentioned this pull request Apr 3, 2023

[PR #6278/cee5f31b backport][stable-6] Add support to topics on Gitlab Project module #6283

Merged

felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Apr 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support to topics on Gitlab Project module #6278

Add support to topics on Gitlab Project module #6278

tanganellilore commented Apr 3, 2023

ansibullbot commented Apr 3, 2023

ansibullbot commented Apr 3, 2023

github-actions bot commented Apr 3, 2023 •

edited

felixfontein left a comment

tanganellilore commented Apr 3, 2023

nejch left a comment

patchback bot commented Apr 3, 2023 •

edited

felixfontein commented Apr 3, 2023

Add support to topics on Gitlab Project module #6278

Add support to topics on Gitlab Project module #6278

Conversation

tanganellilore commented Apr 3, 2023

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

ansibullbot commented Apr 3, 2023

ansibullbot commented Apr 3, 2023

github-actions bot commented Apr 3, 2023 • edited

Docs Build 📝

felixfontein left a comment

Choose a reason for hiding this comment

tanganellilore commented Apr 3, 2023

nejch left a comment

Choose a reason for hiding this comment

patchback bot commented Apr 3, 2023 • edited

Backport to stable-6: 💚 backport PR created

felixfontein commented Apr 3, 2023

github-actions bot commented Apr 3, 2023 •

edited

patchback bot commented Apr 3, 2023 •

edited