-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rundeck modules fixes and improvements #6300
Rundeck modules fixes and improvements #6300
Conversation
@phsmith this PR contains the following merge commits: Please rebase your branch to remove these commits. |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Please add a changelog fragment. I've added some first comments below.
I would also suggest to avoid mixing refactoring and new features if not strictly necessary. It's better to do new features in a follow-up PR to avoid making this PR too complex.
666c625
to
0b2670a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @phsmith thanks for your contribution!
I caught a typo and a couple of nit picking on the changelog fragment.
changelogs/fragments/6300-rundeck-modules-fixes-and-improvements.yml
Outdated
Show resolved
Hide resolved
changelogs/fragments/6300-rundeck-modules-fixes-and-improvements.yml
Outdated
Show resolved
Hide resolved
changelogs/fragments/6300-rundeck-modules-fixes-and-improvements.yml
Outdated
Show resolved
Hide resolved
changelogs/fragments/6300-rundeck-modules-fixes-and-improvements.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6343 🤖 @patchback |
* feat: add token alias to api_token parameter * fix: return (None, info) on empty content response * feat: update the modules for using module_utils.rundeck funcs * docs: add changelog fragment * fix: add trailing commas * fix: changelog fragment invalid syntax * fix: changelog typos * fix: remove token aliases from api_token * fix: add token alias to api_token param * fix: add partial overwrite of params and docs (cherry picked from commit a35542d)
Thanks @russoz and @felixfontein! |
…ovements (#6343) Rundeck modules fixes and improvements (#6300) * feat: add token alias to api_token parameter * fix: return (None, info) on empty content response * feat: update the modules for using module_utils.rundeck funcs * docs: add changelog fragment * fix: add trailing commas * fix: changelog fragment invalid syntax * fix: changelog typos * fix: remove token aliases from api_token * fix: add token alias to api_token param * fix: add partial overwrite of params and docs (cherry picked from commit a35542d) Co-authored-by: Phillipe Smith <phsmithcc@gmail.com>
SUMMARY
Following PR #5887 and issue #5742, I've made some updates and improvements to the
rundeck_acl_policy
andrundeck_project
modules to fix the issues and make them more standard.Fixes #5742
ISSUE TYPE
COMPONENT NAME
ADDITIONAL INFORMATION
module_utils.rundeck
functions and argumentsmodule_utils.rundeck