Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnsimple_info: minor refactor #6440

Merged
merged 2 commits into from
May 3, 2023
Merged

dnsimple_info: minor refactor #6440

merged 2 commits into from
May 3, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Apr 27, 2023

SUMMARY

Minor refactor in module.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

dnsimple_info

@ansibullbot
Copy link
Collaborator

cc @edhilgendorf
click here for bot help

@ansibullbot ansibullbot added module module plugins plugin (any type) labels Apr 27, 2023
@felixfontein felixfontein changed the title dns_simple: minor refactor dnsimple_info: minor refactor Apr 28, 2023
felixfontein
felixfontein approved these changes Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's restart the CI though since now the tests actually run ;)

@felixfontein
Copy link
Collaborator

Restarting

@felixfontein felixfontein reopened this Apr 28, 2023
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Apr 28, 2023
@felixfontein
Copy link
Collaborator

Will merge in a couple of days if nobody objects.

@felixfontein felixfontein merged commit 27a3d6d into ansible-collections:main May 3, 2023
@felixfontein
Copy link
Collaborator

@russoz thanks!

@russoz russoz deleted the dnsimple_info_refactor branch May 3, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@russoz @ansibullbot @felixfontein