Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snap_alias: refactor code out to module utils #6441

Merged
merged 2 commits into from
Apr 28, 2023
Merged

snap_alias: refactor code out to module utils #6441

merged 2 commits into from
Apr 28, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented Apr 27, 2023

SUMMARY

Minor refactor in snap_alias, moving the CmdRunner object creation to module utils. This will later be reused by the snap module and the upcoming snap_info one.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

snap_alias

@ansibullbot ansibullbot added module module module_utils module_utils plugins plugin (any type) labels Apr 27, 2023
felixfontein
felixfontein reviewed Apr 28, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@felixfontein felixfontein merged commit d4df585 into ansible-collections:main Apr 28, 2023
@felixfontein
Copy link
Collaborator

@russoz thanks!

@russoz russoz deleted the snap-alias-cmdrunnner-refactor branch April 28, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
module_utils module_utils module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@russoz @felixfontein @ansibullbot