modules/proxmox_kvm: initial support for online migrations #6448
Conversation
ansibullbot
added
feature
felixfontein
added
the
check-before-release
| @@ -1256,6 +1283,18 @@ def main(): | |||
| except Exception as e: | |||
| module.fail_json(vmid=vmid, msg='Unable to revert settings on VM {0} with vmid {1}: Maybe is not a pending task... '.format(name, vmid) + str(e)) | |||
|
|
|||
| if migrate: | |||
There was a problem hiding this comment.
I find it a bit strange that this overrides state=absent, but then the other options above do it the same way.
There was a problem hiding this comment.
Well as it is, migrate would fail on the proxmox.get_vm(vmid) if it does not exist in the cluster, but indeed it will never ensure states when migrate (or previous actions) is True. The way I see it, users need to define several tasks: one for managing the state and one or more for specific actions (clone, delete, revert and migrate).
There was a problem hiding this comment.
Nevermind, I just re-read this part and clone does not prevent state management. We could do the same for migrate, but having state and migrate as mutually exclusive options seems easier to implement.
Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Co-authored-by: Felix Fontein <felix@fontein.de>
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
removed
the
check-before-release
|
@tyxieblub thanks for your contribution! |
SUMMARY
I found myself wanting to use the
proxmox_kvmmodule to migrate VM on different hosts, so I propose this change to do that by adding themigrateoption, which isFalseby default (to prevent any breaking of existing playbooks).ISSUE TYPE
COMPONENT NAME
proxmox_kvm