Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpanm: deprecate default mode #6512

Merged
merged 2 commits into from
May 29, 2023
Merged

cpanm: deprecate default mode #6512

merged 2 commits into from
May 29, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented May 10, 2023

SUMMARY

Deprecate value compatibility as the default for parameter mode.

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

cpanm

@ansibullbot
Copy link
Collaborator

cc @fcuny
click here for bot help

@ansibullbot ansibullbot added module module plugins plugin (any type) labels May 10, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 Automatically create a backport for the stable-7 branch labels May 11, 2023
felixfontein
felixfontein approved these changes May 14, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like something that should have been done some versions ago :) Let's do it!

To be merged for 7.1.0.

@russoz
Copy link
Collaborator Author

russoz commented May 14, 2023

Yup, this one slipped through the cracks.

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label May 22, 2023
@felixfontein felixfontein merged commit 64f74e1 into ansible-collections:main May 29, 2023
@patchback
Copy link

patchback bot commented May 29, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/64f74e122834b069b9fb5171a503a25a13fbe139/pr-6512

Backported as #6589

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 29, 2023
@felixfontein
Copy link
Collaborator

@russoz thanks!

patchback bot pushed a commit that referenced this pull request May 29, 2023
@russoz @patchback
cpanm: deprecate default mode (#6512)
e3d21e1 
* cpanm: deprecate default mode

* add changelog frag

(cherry picked from commit 64f74e1)
@patchback patchback bot mentioned this pull request May 29, 2023
Merged
felixfontein pushed a commit that referenced this pull request May 29, 2023
@patchback @russoz
[PR #6512/64f74e12 backport][stable-7] cpanm: deprecate default mode (#…
f663fe7 
…6589)

cpanm: deprecate default mode (#6512)

* cpanm: deprecate default mode

* add changelog frag

(cherry picked from commit 64f74e1)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the cpanm-change-default-mode branch May 29, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-7 Automatically create a backport for the stable-7 branch module module plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@russoz @ansibullbot @felixfontein