Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorcery: moved import to top #6525

Merged
merged 3 commits into from
May 29, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented May 16, 2023

SUMMARY

Moved import stmt from bottom to the top-ish of the file

ISSUE TYPE
  • Refactoring Pull Request
COMPONENT NAME

sorcery

@ansibullbot
Copy link
Collaborator

cc @vaygr
click here for bot help

@ansibullbot ansibullbot added module module plugins plugin (any type) labels May 16, 2023
@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label May 16, 2023
Co-authored-by: Vlad Glagolev <vaygr@users.noreply.github.com>
@ansibullbot ansibullbot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels May 16, 2023
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merge for 7.1.0.

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 Automatically create a backport for the stable-7 branch labels May 17, 2023
@ansibullbot ansibullbot added stale_ci CI is older than 7 days, rerun before merging stale_review labels May 25, 2023
@felixfontein felixfontein merged commit 4c0eff0 into ansible-collections:main May 29, 2023
@patchback
Copy link

patchback bot commented May 29, 2023

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/4c0eff02e52b80701a59a2677ff857b20ddf1e25/pr-6525

Backported as #6595

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 29, 2023
patchback bot pushed a commit that referenced this pull request May 29, 2023
* sorcery: moved import to top

* add changelog frag

* Update changelogs/fragments/6525-sorcery-import.yaml

Co-authored-by: Vlad Glagolev <vaygr@users.noreply.github.com>

---------

Co-authored-by: Vlad Glagolev <vaygr@users.noreply.github.com>
(cherry picked from commit 4c0eff0)
@felixfontein
Copy link
Collaborator

@russoz thanks for your contribution!
@vaygr thanks for reviewing!

felixfontein pushed a commit that referenced this pull request May 29, 2023
…6595)

sorcery: moved import to top (#6525)

* sorcery: moved import to top

* add changelog frag

* Update changelogs/fragments/6525-sorcery-import.yaml

Co-authored-by: Vlad Glagolev <vaygr@users.noreply.github.com>

---------

Co-authored-by: Vlad Glagolev <vaygr@users.noreply.github.com>
(cherry picked from commit 4c0eff0)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
@russoz russoz deleted the sorcery-import branch May 29, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7 Automatically create a backport for the stable-7 branch module module needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging stale_review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants