-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sorcery: moved import to top #6525
Merged
felixfontein
merged 3 commits into
ansible-collections:main
from
russoz-ansible:sorcery-import
May 29, 2023
Merged
sorcery: moved import to top #6525
felixfontein
merged 3 commits into
ansible-collections:main
from
russoz-ansible:sorcery-import
May 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaygr
suggested changes
May 16, 2023
Co-authored-by: Vlad Glagolev <vaygr@users.noreply.github.com>
felixfontein
approved these changes
May 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will merge for 7.1.0.
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6595 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
May 29, 2023
* sorcery: moved import to top * add changelog frag * Update changelogs/fragments/6525-sorcery-import.yaml Co-authored-by: Vlad Glagolev <vaygr@users.noreply.github.com> --------- Co-authored-by: Vlad Glagolev <vaygr@users.noreply.github.com> (cherry picked from commit 4c0eff0)
felixfontein
pushed a commit
that referenced
this pull request
May 29, 2023
…6595) sorcery: moved import to top (#6525) * sorcery: moved import to top * add changelog frag * Update changelogs/fragments/6525-sorcery-import.yaml Co-authored-by: Vlad Glagolev <vaygr@users.noreply.github.com> --------- Co-authored-by: Vlad Glagolev <vaygr@users.noreply.github.com> (cherry picked from commit 4c0eff0) Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-7
Automatically create a backport for the stable-7 branch
module
module
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR
plugins
plugin (any type)
stale_ci
CI is older than 7 days, rerun before merging
stale_review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Moved import stmt from bottom to the top-ish of the file
ISSUE TYPE
COMPONENT NAME
sorcery