Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CmdRunner module utils: deprecate format method as_default_type() #6601

Merged
merged 2 commits into from
May 31, 2023
Merged

CmdRunner module utils: deprecate format method as_default_type() #6601

merged 2 commits into from
May 31, 2023

Conversation

russoz
Copy link
Collaborator

@russoz russoz commented May 29, 2023

SUMMARY

Deprecate cmd_runner_fmt.as_default_type()

ISSUE TYPE
  • Docs Pull Request
  • Refactoring Pull Request
COMPONENT NAME

plugins/module_utils/cmd_runner.py

@russoz russoz force-pushed the cmdrunner_deprecate_default_type branch from 9da3ca6 to fbee9df Compare May 29, 2023 20:44
@ansibullbot ansibullbot added docs module_utils module_utils plugins plugin (any type) small_patch Hopefully easy to review labels May 29, 2023
@ansibullbot ansibullbot removed the small_patch Hopefully easy to review label May 29, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 Automatically create a backport for the stable-7 branch labels May 30, 2023
@felixfontein felixfontein merged commit c9aae5e into ansible-collections:main May 31, 2023
135 checks passed
@patchback
Copy link

patchback bot commented May 31, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/c9aae5e45cdf789cd0133346f699ad9ae8cbd432/pr-6601

Backported as #6609

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@russoz thanks!

@patchback patchback bot mentioned this pull request May 31, 2023
Merged
patchback bot pushed a commit that referenced this pull request May 31, 2023
@russoz @patchback
CmdRunner module utils: deprecate format method as_default_type() (#…
0b611db 
…6601)

* CmdRunner module utils: deprecate format method `as_default_type()`

* add changelog frag

(cherry picked from commit c9aae5e)
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label May 31, 2023
@russoz russoz deleted the cmdrunner_deprecate_default_type branch May 31, 2023 06:21
felixfontein pushed a commit that referenced this pull request May 31, 2023
@patchback @russoz
[PR #6601/c9aae5e4 backport][stable-7] CmdRunner module utils: deprec…
41b5464 
…ate format method `as_default_type()` (#6609)

CmdRunner module utils: deprecate format method `as_default_type()` (#6601)

* CmdRunner module utils: deprecate format method `as_default_type()`

* add changelog frag

(cherry picked from commit c9aae5e)

Co-authored-by: Alexei Znamensky <103110+russoz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein approved these changes

Assignees
No one assigned
Labels
backport-7 Automatically create a backport for the stable-7 branch docs module_utils module_utils plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@russoz @felixfontein @ansibullbot