redhat_subscription: officially deprecate "autosubscribe" #6646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
reviewed
Jun 9, 2023
felixfontein
added
check-before-release
This comment was marked as outdated.
This comment was marked as outdated.
|
@ptoscano: Greetings! Thanks for taking the time to open this pullrequest. In order for the community to handle your pullrequest effectively, we need a bit more information. Here are the items we could not find in your description:
Please set the description of this pullrequest with this template: |
ansibullbot
added
ci_verified
felixfontein
reviewed
Jun 9, 2023
Sure; I always send the PR first, since the changelog fragment needs the PR number in its filename and in its text. Also: I did not select any issue type, as I did not think any of all the existing ones would fit. Is it ok? |
ptoscano
force-pushed
the
redhat_subscription-deprecate-autosubscribe
branch
from
c99b182
to
57b8fc1
Compare
The "autosubscribe" alias for the "auto_attach" option has been deprecated for many years, although only in the documentation. Officially mark it as deprecated also in the module parameters spec, slating it for removal in 9.0.0.
ptoscano
force-pushed
the
redhat_subscription-deprecate-autosubscribe
branch
from
57b8fc1
to
fd757fa
Compare
ansibullbot
added
docs
and removed
ci_verified
felixfontein
approved these changes
Jun 9, 2023
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6655 🤖 @patchback |
|
@ptoscano thanks! |
patchback bot
pushed a commit
that referenced
this pull request
Jun 9, 2023
The "autosubscribe" alias for the "auto_attach" option has been deprecated for many years, although only in the documentation. Officially mark it as deprecated also in the module parameters spec, slating it for removal in 9.0.0. (cherry picked from commit 621bedf)
felixfontein
pushed a commit
that referenced
this pull request
Jun 9, 2023
…y deprecate "autosubscribe" (#6655) redhat_subscription: officially deprecate "autosubscribe" (#6646) The "autosubscribe" alias for the "auto_attach" option has been deprecated for many years, although only in the documentation. Officially mark it as deprecated also in the module parameters spec, slating it for removal in 9.0.0. (cherry picked from commit 621bedf) Co-authored-by: Pino Toscano <ptoscano@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
autosubscribealias for theauto_attachoption has been deprecated for many years, although only in the documentation. Officially mark it as deprecated also in the module parameters spec, slating it for removal in 9.0.0.The short deprecation time is because of the following reasons:
auto_attachwas introduced many years ago, so even if you rely on e.g. Ansible 2.9, that option is there alreadyautosubscribetoauto_attachis very easyISSUE TYPE
COMPONENT NAME
redhat_subscription