VarDict: convenience methods #6647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
feature
felixfontein
added
check-before-release
felixfontein
reviewed
Jun 9, 2023
| @@ -93,7 +106,7 @@ def __str__(self): | |||
|
|
|||
|
|
|||
| class VarDict(object): | |||
| reserved_names = ('__vars__', 'var', 'set_meta', 'set', 'output', 'diff', 'facts', 'has_changed') | |||
| reserved_names = ('__vars__', '_var', 'var', 'set_meta', 'get_meta', 'set', 'output', 'diff', 'facts', 'has_changed', 'as_dict') | |||
There was a problem hiding this comment.
Hmm, isn't changing this field a breaking change (since now using _var, get_meta, and as_dict is illegal and will result in an exception)?
There was a problem hiding this comment.
I guess it is - I had not considered it from that perspective. Will update the changelog fragment, but cannot escape from that.
There was a problem hiding this comment.
Hmm, in that case we should probably only merge it for 8.0.0 and not backport it to stable-7.
felixfontein
added
breaking_change
felixfontein
approved these changes
Jun 11, 2023
felixfontein
removed
the
check-before-release
|
@russoz thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Add convenience methods for variables and the
VarDictclass.ISSUE TYPE
COMPONENT NAME
plugins/module_utils/vardict.py