Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onepassword lookup add service accounts #6660
Onepassword lookup add service accounts #6660
Changes from 9 commits
9070a5a
eb6352e
07ba8cf
e831a25
095562a
f7cb8ed
f007397
375d6d5
90abfb7
ae94bbf
4ab33a6
d12b22a
9c15c70
a67bfea
7163369
a793b59
90461c7
9904b2d
ccaf67d
1434ecd
f61fbe1
9090651
d34a9c7
fc0d07d
f98620f
7b4b61c
e53fb70
a2870a8
c233708
b6290c5
5e7f8f7
a0bfb65
ce5c38f
990328f
7cc6c5f
df8a5a9
b1fae64
48b36b8
4346b29
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will skip parameter validation for
OnePassCLIv1
. Even if this won't be called by methods in aOnePassCLIv1
object in the current plugin code, this should do the right thing when called in isolation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this method should change. Instead, have the caller decide whether calling this method is even necessary. That should be two places is the
OnePassCLIv2
class.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still probably necessary as it checks that the token is valid.
The
else
can be removed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this command me
op user get --me
as the docs suggest?op whoami
is also sufficient.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this should ignore errors. If the token is invalid, this should raise an
AnsibleLookupError
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes aren't needed since
full_signin
will be skipped if there is service token. If there is a problem with the service token, the lookup will exit before getting here.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This space can stay.