Deprecate module_utils.redhat #6663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module contains bits that are either unused (the Rhsm* classes), or used only by deprecated modules (the RegistrationBase class). Considering that the bits here have not seen updates in years, it is unlikely that anyone is actually using them as "library". Hence, deprecate the whole module altogether: - the Rhsm* classes, as not used by anything, are slated for removal in 9.0.0 - the RegistrationBase class is slated for removal in 10.0.0, together with its only user (i.e. the rhn_register module)
ptoscano
force-pushed
the
deprecate-module_utils.redhat
branch
from
b516763
to
2d3617b
Compare
felixfontein
approved these changes
Jun 10, 2023
felixfontein
added
the
backport-7
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6666 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 10, 2023
This module contains bits that are either unused (the Rhsm* classes), or used only by deprecated modules (the RegistrationBase class). Considering that the bits here have not seen updates in years, it is unlikely that anyone is actually using them as "library". Hence, deprecate the whole module altogether: - the Rhsm* classes, as not used by anything, are slated for removal in 9.0.0 - the RegistrationBase class is slated for removal in 10.0.0, together with its only user (i.e. the rhn_register module) (cherry picked from commit 78c42de)
|
@ptoscano thanks for your contribution! |
felixfontein
pushed a commit
that referenced
this pull request
Jun 10, 2023
…6666) Deprecate module_utils.redhat (#6663) This module contains bits that are either unused (the Rhsm* classes), or used only by deprecated modules (the RegistrationBase class). Considering that the bits here have not seen updates in years, it is unlikely that anyone is actually using them as "library". Hence, deprecate the whole module altogether: - the Rhsm* classes, as not used by anything, are slated for removal in 9.0.0 - the RegistrationBase class is slated for removal in 10.0.0, together with its only user (i.e. the rhn_register module) (cherry picked from commit 78c42de) Co-authored-by: Pino Toscano <ptoscano@redhat.com>
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This module contains bits that are either unused (the
Rhsm*classes), or used only by deprecated modules (theRegistrationBaseclass). Considering that the bits here have not seen updates in years, it is unlikely that anyone is actually using them as "library".Hence, deprecate the whole module altogether:
Rhsm*classes, as not used by anything, are slated for removal in 9.0.0RegistrationBaseclass is slated for removal in 10.0.0, together with its only user (i.e. therhn_registermodule)ISSUE TYPE
COMPONENT NAME
plugins/module_utils/redhat.py