Fix composites comparison for role in is_struct_included keycloak.py … #6688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
added
check-before-release
changelogs/fragments/6688-is-struct-included-bug-in-keycloak-py.yml
Outdated
Show resolved
Hide resolved
…y.yml Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
removed
the
check-before-release
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6689 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
#6688) * Fix composites comparison for role in is_struct_included keycloak.py function * Add changelog fragment and unit tests * Update changelogs/fragments/6688-is-struct-included-bug-in-keycloak-py.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 032996e)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6690 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Jun 14, 2023
#6688) * Fix composites comparison for role in is_struct_included keycloak.py function * Add changelog fragment and unit tests * Update changelogs/fragments/6688-is-struct-included-bug-in-keycloak-py.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 032996e)
|
@elfelip thanks a lot! |
felixfontein
pushed a commit
that referenced
this pull request
Jun 14, 2023
…role in is_struct_included keycloak.py … (#6689) Fix composites comparison for role in is_struct_included keycloak.py … (#6688) * Fix composites comparison for role in is_struct_included keycloak.py function * Add changelog fragment and unit tests * Update changelogs/fragments/6688-is-struct-included-bug-in-keycloak-py.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 032996e) Co-authored-by: Philippe Gauthier <philippe.gauthier@inspq.qc.ca>
felixfontein
pushed a commit
that referenced
this pull request
Jun 14, 2023
…role in is_struct_included keycloak.py … (#6690) Fix composites comparison for role in is_struct_included keycloak.py … (#6688) * Fix composites comparison for role in is_struct_included keycloak.py function * Add changelog fragment and unit tests * Update changelogs/fragments/6688-is-struct-included-bug-in-keycloak-py.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 032996e) Co-authored-by: Philippe Gauthier <philippe.gauthier@inspq.qc.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix comparison problem with is_struct_included function of keycloak.py module utils.
SUMMARY
This apply when we compare composite in keycloak roles to detect if a change is needed.
ISSUE TYPE
COMPONENT NAME
keycloak.py module utils
ADDITIONAL INFORMATION
This fis is needed to support composites in Keycloak roles.