Fix Keycloak authentication management indexing #6734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
bug
felixfontein
added
check-before-release
This comment was marked as outdated.
This comment was marked as outdated.
ansibullbot
added
the
needs_revision
ansibullbot
removed
the
needs_revision
There was a problem hiding this comment.
Thanks for your contribution! Could you please add a changelog fragment?
The choices addition would be an entry in minor_changes, the bugfix an entry in bugfixes. Please note that if you keep all changes in one PR, the bugfix cannot be backported to community.general 6.x.y.
|
I'll open a new PR for the minor changes, so the bugfix in this one can be backported. |
This was referenced Jun 21, 2023
changelogs/fragments/6734-keycloak-auth-management-indexing.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6894 🤖 @patchback |
|
@Skrekulko thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Jul 8, 2023
* fix: keep original index * refac: provider id choice * refac: default * fix: missing docs * fix: ident * fix: yaml formatting * chore: bugfix changelog fragment * fix: remove minor changes form current PR * fix: missing yml extension * Update changelogs/fragments/6734-keycloak-auth-management-indexing.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Skrekulko <Skrekulko@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 7748002)
felixfontein
pushed a commit
that referenced
this pull request
Jul 8, 2023
…nagement indexing (#6894) Fix Keycloak authentication management indexing (#6734) * fix: keep original index * refac: provider id choice * refac: default * fix: missing docs * fix: ident * fix: yaml formatting * chore: bugfix changelog fragment * fix: remove minor changes form current PR * fix: missing yml extension * Update changelogs/fragments/6734-keycloak-auth-management-indexing.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Skrekulko <Skrekulko@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 7748002) Co-authored-by: Skrekulko <111891715+Skrekulko@users.noreply.github.com>
valeriopoggi
pushed a commit
to valeriopoggi/community.general
that referenced
this pull request
Jul 17, 2023
…6734) * fix: keep original index * refac: provider id choice * refac: default * fix: missing docs * fix: ident * fix: yaml formatting * chore: bugfix changelog fragment * fix: remove minor changes form current PR * fix: missing yml extension * Update changelogs/fragments/6734-keycloak-auth-management-indexing.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Skrekulko <Skrekulko@users.noreply.github.com> Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes an issue with indexation during the update of an authentication flow, more specifically a step (execution or sub-flow). The older behavior caused the to-be-updated step to change its index, even though the user didn't specify it.
Next (even though this is a refac), the provider ID according to Keycloak can only be basic-flow or client-flow. So I introduced choices for it.
ISSUE TYPE
COMPONENT NAME
keycloak_authentication