Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nmcli: fix empty list to replace / remove values #6769

Merged
merged 1 commit into from
Jul 6, 2023
Merged

nmcli: fix empty list to replace / remove values #6769

merged 1 commit into from
Jul 6, 2023

Conversation

genofire
Copy link
Contributor

SUMMARY

Fixes #6574

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • New Module/Plugin Pull Request
  • Refactoring Pull Request
  • Test Pull Request
COMPONENT NAME

nmcli

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

cc @alcamie101
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug module module plugins plugin (any type) small_patch Hopefully easy to review labels Jun 22, 2023
@ansibullbot ansibullbot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI and removed small_patch Hopefully easy to review labels Jun 22, 2023
@genofire genofire marked this pull request as ready for review June 22, 2023 17:14
@genofire
Copy link
Contributor Author

huhu @yan12125 thanks for this patch, so i make therefore this PR to bring it upstream

@ansibullbot ansibullbot removed WIP Work in progress needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI labels Jun 22, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 backport-7 Automatically create a backport for the stable-7 branch labels Jun 24, 2023
@yan12125
Copy link
Contributor

Regarding needs_ci label: I have a proof-of-concept test at https://github.com/yan12125/community.general/commit/2965eabdb6f0202f426e0a1ec5c3d8a98af560b2. Didn't submit a PR, though, as I don't know how to properly mock module._diff.

@felixfontein
Copy link
Collaborator

@yan12125 passing '_ansible_diff': True as a module option should do the trick. (Similar to how '_ansible_check_mode' corresponds to check mode.)

@yan12125
Copy link
Contributor

Thanks a lot for the hint! I updated the test: https://github.com/yan12125/community.general/commit/a6848376f4b2b09282bbfdda21f0da6ebe897aa8

@genofire could you pull that commit into this PR?

@ansibullbot ansibullbot added tests tests unit tests/unit labels Jun 28, 2023
@genofire
Copy link
Contributor Author

@yan12125 thanks for the tests.

lets be reviewed and merged xD

@felixfontein
Copy link
Collaborator

Assuming this change works fine for both of you, I'll probably merge this in a week if nobody objects.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 6, 2023
@felixfontein felixfontein merged commit 9d8bec1 into ansible-collections:main Jul 6, 2023
151 checks passed
@patchback
Copy link

patchback bot commented Jul 6, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/9d8bec14c09cc79448b925784b3e8347d78bb17e/pr-6769

Backported as #6868

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 6, 2023
@genofire @patchback
nmcli: fix empty list to replace / remove values (#6769)
69b227b 
(cherry picked from commit 9d8bec1)
@patchback patchback bot mentioned this pull request Jul 6, 2023
Merged
@patchback
Copy link

patchback bot commented Jul 6, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/9d8bec14c09cc79448b925784b3e8347d78bb17e/pr-6769

Backported as #6869

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@genofire @yan12125 thanks a lot for your contribution!

patchback bot pushed a commit that referenced this pull request Jul 6, 2023
@genofire @patchback
nmcli: fix empty list to replace / remove values (#6769)
869b21a 
(cherry picked from commit 9d8bec1)
@patchback patchback bot mentioned this pull request Jul 6, 2023
Merged
felixfontein pushed a commit that referenced this pull request Jul 6, 2023
@patchback @genofire
[PR #6769/9d8bec14 backport][stable-6] nmcli: fix empty list to repla…
443a1c3 
…ce / remove values (#6868)

nmcli: fix empty list to replace / remove values (#6769)

(cherry picked from commit 9d8bec1)

Co-authored-by: genofire <geno+dev@fireorbit.de>
felixfontein pushed a commit that referenced this pull request Jul 6, 2023
@patchback @genofire
[PR #6769/9d8bec14 backport][stable-7] nmcli: fix empty list to repla…
330b030 
…ce / remove values (#6869)

nmcli: fix empty list to replace / remove values (#6769)

(cherry picked from commit 9d8bec1)

Co-authored-by: genofire <geno+dev@fireorbit.de>
@genofire genofire deleted the patch-1 branch July 6, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-7 Automatically create a backport for the stable-7 branch bug This issue/PR relates to a bug module module plugins plugin (any type) tests tests unit tests/unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nmcli: clear out routes4_extended
4 participants
@genofire @ansibullbot @yan12125 @felixfontein