-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proxmox_kvm: Add required timeout arg when force deleting #6827
proxmox_kvm: Add required timeout arg when force deleting #6827
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
changelogs/fragments/6827-proxmox_kvm-force-delete-bug-fix.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Felix Fontein <felix@fontein.de>
If nobody objects I'll merge this in ~a week. |
Yeah, my bad. I introduced one more param to the function and looks like didn't update that function call in all places. |
Backport to stable-6: 💚 backport PR created✅ Backport PR branch: Backported as #6865 🤖 @patchback |
* Add required timeout arg when force deleting * Add changelog fragment * Update changelogs/fragments/6827-proxmox_kvm-force-delete-bug-fix.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 216962a)
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6866 🤖 @patchback |
* Add required timeout arg when force deleting * Add changelog fragment * Update changelogs/fragments/6827-proxmox_kvm-force-delete-bug-fix.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 216962a)
@drewburr thanks for your contribution! |
…out arg when force deleting (#6865) proxmox_kvm: Add required timeout arg when force deleting (#6827) * Add required timeout arg when force deleting * Add changelog fragment * Update changelogs/fragments/6827-proxmox_kvm-force-delete-bug-fix.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 216962a) Co-authored-by: Drew Brown <drew@drewburr.com>
…out arg when force deleting (#6866) proxmox_kvm: Add required timeout arg when force deleting (#6827) * Add required timeout arg when force deleting * Add changelog fragment * Update changelogs/fragments/6827-proxmox_kvm-force-delete-bug-fix.yaml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit 216962a) Co-authored-by: Drew Brown <drew@drewburr.com>
SUMMARY
When attempting to force delete a VM, the module fails with the following error:
fatal: [localhost]: FAILED! => {"changed": false, "msg": "deletion of VM 102 failed with exception: ProxmoxKvmAnsible.stop_vm() missing 1 required positional argument: 'timeout'"}
ISSUE TYPE
COMPONENT NAME
proxmox_kvm
ADDITIONAL INFORMATION
This is caused by
proxmox_kvm
not passing the module's timeout argument to thestop_vm()
method. This PR adds the passing of said timeout value.Example task: