Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machinectl become plugin: mark as require_tty #6935

Merged
merged 1 commit into from
Jul 15, 2023
Merged

machinectl become plugin: mark as require_tty #6935

merged 1 commit into from
Jul 15, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fixes #6932.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

machinectl become plugin

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-6 backport-7 Automatically create a backport for the stable-7 branch labels Jul 14, 2023
@felixfontein
Copy link
Collaborator Author

@bcoca thanks for reporting this; this PR should fix that.

@ansibullbot
Copy link
Collaborator

cc @None
click here for bot help

@ansibullbot ansibullbot added become become plugin bug This issue/PR relates to a bug plugins plugin (any type) labels Jul 14, 2023
@felixfontein felixfontein merged commit 24feb1d into ansible-collections:main Jul 15, 2023
151 checks passed
@patchback
Copy link

patchback bot commented Jul 15, 2023 •
edited
Loading

Backport to stable-6: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-6/24feb1dd10f86c87a4fac623dd9095f7ead3c8b7/pr-6935

Backported as #6941

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Jul 15, 2023
patchback bot pushed a commit that referenced this pull request Jul 15, 2023
@felixfontein @patchback
machinectl become plugin: mark as require_tty (#6935)
38c3f67 
Mark machinectl become plugin as require_tty.

(cherry picked from commit 24feb1d)
@patchback patchback bot mentioned this pull request Jul 15, 2023
Merged
@patchback
Copy link

patchback bot commented Jul 15, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/24feb1dd10f86c87a4fac623dd9095f7ead3c8b7/pr-6935

Backported as #6942

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jul 15, 2023
@felixfontein @patchback
machinectl become plugin: mark as require_tty (#6935)
9c1f814 
Mark machinectl become plugin as require_tty.

(cherry picked from commit 24feb1d)
@patchback patchback bot mentioned this pull request Jul 15, 2023
Merged
@felixfontein felixfontein deleted the machinectl branch July 15, 2023 10:55
@felixfontein
Copy link
Collaborator Author

@bcoca @gotmax23 thanks!

felixfontein added a commit that referenced this pull request Jul 15, 2023
@patchback @felixfontein
[PR #6935/24feb1dd backport][stable-6] machinectl become plugin: mark…
3c6c9ba 
… as require_tty (#6941)

machinectl become plugin: mark as require_tty (#6935)

Mark machinectl become plugin as require_tty.

(cherry picked from commit 24feb1d)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Jul 15, 2023
@patchback @felixfontein
[PR #6935/24feb1dd backport][stable-7] machinectl become plugin: mark…
f317fd9 
… as require_tty (#6942)

machinectl become plugin: mark as require_tty (#6935)

Mark machinectl become plugin as require_tty.

(cherry picked from commit 24feb1d)

Co-authored-by: Felix Fontein <felix@fontein.de>
valeriopoggi pushed a commit to valeriopoggi/community.general that referenced this pull request Jul 17, 2023
@felixfontein @valeriopoggi
machinectl become plugin: mark as require_tty (ansible-collections#6935)
9f2c8e2 
Mark machinectl become plugin as require_tty.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gotmax23 gotmax23 gotmax23 approved these changes

Assignees
No one assigned
Labels
backport-7 Automatically create a backport for the stable-7 branch become become plugin bug This issue/PR relates to a bug plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

machinectl become plugin does not specify it requires a tty
3 participants
@felixfontein @ansibullbot @gotmax23