[proxmox_vm_info] Re-use cluster resources API to use module without requiring node param #6976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@felixfontein let me know please what type of change is it and should we mention somewhere that |
ansibullbot
added
feature
felixfontein
added
check-before-release
|
@UnderGreen I would say this is a new feature, so it's a |
UnderGreen
force-pushed
the
proxmox/reuse-cluster-resources
branch
from
3dbf7bd
to
8533e31
Compare
1 task
|
I'll merge in a couple of days if nobody objects. |
felixfontein
removed
the
check-before-release
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #6993 🤖 @patchback |
|
@UnderGreen thanks for this one as well! |
felixfontein
pushed a commit
that referenced
this pull request
Jul 23, 2023
…er resources API to use module without requiring node param (#6993) [proxmox_vm_info] Re-use cluster resources API to use module without requiring node param (#6976) * [proxmox_vm_info] Re-use cluster resources API to use module without requiring node param * More consife if * Fix use case when requesting all vms from specific node * Add changelog fragment (cherry picked from commit d7c1a81) Co-authored-by: Sergei Antipov <greendayonfire@gmail.com>
felixfontein
added a commit
to felixfontein/community.general
that referenced
this pull request
Jul 31, 2023
…oxmox_vm_info] Re-use cluster resources API to use module without requiring node param (ansible-collections#6993)" This reverts commit fb3768a.
felixfontein
added a commit
that referenced
this pull request
Jul 31, 2023
* Revert "[PR #7020/b46d5d81 backport][stable-7] redfish_utils: Add support for "nextLink" property tag pagination (#7026)" This reverts commit 1dad953. * Revert "[PR #6914/17b4219b backport][stable-7] proxmox_kvm: enable 'force' restart of vm (as documented) (#6997)" This reverts commit 7d68af5. * Revert "[PR #6976/d7c1a814 backport][stable-7] [proxmox_vm_info] Re-use cluster resources API to use module without requiring node param (#6993)" This reverts commit fb3768a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
As requested in comment module can re-use cluster/resources API to get first information about VMs. Then that info is enriched from lxc/qemu API responses.
In that case we can retrieve VM(s) info without requiring node parameter.
ISSUE TYPE
COMPONENT NAME
proxmox_vm_info
ADDITIONAL INFORMATION