chroot: add disable_root_check option
#7099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibullbot
added
connection
There was a problem hiding this comment.
Thanks for your contribution! Please add a changelog fragment. Thanks.
felixfontein
added
check-before-release
Co-authored-by: Felix Fontein <felix@fontein.de>
|
Added. |
ansibullbot
added
the
needs_revision
Co-authored-by: Felix Fontein <felix@fontein.de>
|
The remaining CI failures are unrelated. Looks good to me, if nobody objects I'll merge this on Monday. |
felixfontein
removed
the
check-before-release
felixfontein
merged commit bf728aa
into
ansible-collections:main
149 of 151 checks passed
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7111 🤖 @patchback |
|
@new-sashok724 thanks for your contribution! |
patchback bot
pushed a commit
that referenced
this pull request
Aug 14, 2023
* Initial commit * Update plugins/connection/chroot.py Co-authored-by: Felix Fontein <felix@fontein.de> * Add changelog fragment * Update changelogs/fragments/7099-chroot-disable-root-check-option.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Сашка724ая <git@sashok724.net> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit bf728aa)
felixfontein
pushed a commit
that referenced
this pull request
Aug 14, 2023
…k` option (#7111) chroot: add `disable_root_check` option (#7099) * Initial commit * Update plugins/connection/chroot.py Co-authored-by: Felix Fontein <felix@fontein.de> * Add changelog fragment * Update changelogs/fragments/7099-chroot-disable-root-check-option.yml Co-authored-by: Felix Fontein <felix@fontein.de> --------- Co-authored-by: Сашка724ая <git@sashok724.net> Co-authored-by: Felix Fontein <felix@fontein.de> (cherry picked from commit bf728aa) Co-authored-by: Сашка724ая <github@sashok724.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Some chroot executables, like
arch-chroot, support unshare mode (-N), which does not require root. This PR adds an option to disable the root check in the chroot connection plugin.ISSUE TYPE
COMPONENT NAME
plugins/connection/chroot.pyADDITIONAL INFORMATION