Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freebsd: shutdown -p ... on freebsd to power off machine #7102

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

derekschrock
Copy link
Contributor

  • Use shutdown -p ... on FreeBSD such that the machine is halted and
    powered off (-p) otherwise the machine is halted (-h) but remains on.
SUMMARY

To follow suit with the other shutdown commands that also power off the machine freebsd shutdown should also power off the machine. In that case -p should be used that will halt and power off vs -h that will just halt the machine leave it powered on with a prompt to power off and/or any key to reboot.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

community.general.shutdown

ADDITIONAL INFORMATION

@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added action action plugin bug This issue/PR relates to a bug new_contributor Help guide this first time contributor plugins plugin (any type) labels Aug 12, 2023
* Use shutdown -p ... on FreeBSD such that the machine is halted and
  powered off (-p) otherwise the machine is halted (-h) but remains on.
@ansibullbot ansibullbot added integration tests/integration tests tests needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Aug 12, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 Automatically create a backport for the stable-7 branch labels Aug 13, 2023
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

changelogs/fragments/7102-freebsd-shutdown-p.yml Outdated Show resolved Hide resolved
@felixfontein
Copy link
Collaborator

(The CI errors are unrelated.)

Co-authored-by: Felix Fontein <felix@fontein.de>
@felixfontein
Copy link
Collaborator

I'll merge this tomorrow if nobody objects.

@ansibullbot ansibullbot removed the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Aug 13, 2023
@felixfontein felixfontein merged commit 55cfd27 into ansible-collections:main Aug 14, 2023
145 checks passed
@patchback
Copy link

patchback bot commented Aug 14, 2023

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/55cfd27be99e0b3fe2d324d156445a19d8ad91e7/pr-7102

Backported as #7112

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Aug 14, 2023
patchback bot pushed a commit that referenced this pull request Aug 14, 2023
* freebsd: shutdown -p ... on freebsd to power off machine

* Use shutdown -p ... on FreeBSD such that the machine is halted and
  powered off (-p) otherwise the machine is halted (-h) but remains on.

* Update changelogs/fragments/7102-freebsd-shutdown-p.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 55cfd27)
@felixfontein
Copy link
Collaborator

@derekschrock thanks for your contribution!

felixfontein pushed a commit that referenced this pull request Aug 14, 2023
…eebsd to power off machine (#7112)

freebsd: shutdown -p ... on freebsd to power off machine (#7102)

* freebsd: shutdown -p ... on freebsd to power off machine

* Use shutdown -p ... on FreeBSD such that the machine is halted and
  powered off (-p) otherwise the machine is halted (-h) but remains on.

* Update changelogs/fragments/7102-freebsd-shutdown-p.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 55cfd27)

Co-authored-by: Derek Schrock <dereks@lifeofadishwasher.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action action plugin backport-7 Automatically create a backport for the stable-7 branch bug This issue/PR relates to a bug integration tests/integration new_contributor Help guide this first time contributor plugins plugin (any type) tests tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants