Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proxmox] return vmid and taskid #7263

Merged
merged 11 commits into from
Sep 22, 2023
Merged

[proxmox] return vmid and taskid #7263

merged 11 commits into from
Sep 22, 2023

Commits on Sep 15, 2023

  1. add vmid exit value 

    if create succeeds, we want the vmid
    @b-
    b- committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    db519e1 View commit details
    Browse the repository at this point in the history

  2. fix syntax

    @b-
    b- committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    7028da2 View commit details
    Browse the repository at this point in the history

  3. add vmid to return codes

    @b-
    b- committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    f559275 View commit details
    Browse the repository at this point in the history

  4. Add taskid to return, and only return vmid when it makes sense to

    @b-
    b- committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    74e61e3 View commit details
    Browse the repository at this point in the history

  5. add changelog fragment with temporary filename

    @b-
    b- committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    6f76b1e View commit details
    Browse the repository at this point in the history

  6. Add pr number to fragment

    @b-
    b- committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    86d32ef View commit details
    Browse the repository at this point in the history

  7. fix PEP8 E501: line too long

    @b-
    b- committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    24a1645 View commit details
    Browse the repository at this point in the history

  8. oops, I knew I still missed something...

    @b-
    b- committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    a1557aa View commit details
    Browse the repository at this point in the history

  9. Update 7263-proxmox-return-vmid-and-taskid.yaml 

    Co-authored-by: Felix Fontein <felix@fontein.de>
    @b- @felixfontein
    b- and felixfontein committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    5ae879a View commit details
    Browse the repository at this point in the history

  10. removed taskid from places it's not defined

    @b-
    b- committed Sep 15, 2023
    Configuration menu
    Copy the full SHA
    149992e View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2023

  1. finally fixed sanity test errors 

    Okay, so maybe just waiting for CI to run the tests was a terrible idea.

I installed `inotifywait`, set up a venv for the tests, and in my
editor's terminal pane I ran the following, letting it run every save
until it exited:

    until ansible-test sanity proxmox ; do
        inotifywait --event modify plugins/modules/proxmox.py
    done
    @b-
    b- committed Sep 16, 2023
    Configuration menu
    Copy the full SHA
    9e418a9 View commit details
    Browse the repository at this point in the history