Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties #7471

Merged

Conversation

mraineri
Copy link
Contributor

@mraineri mraineri commented Nov 3, 2023

SUMMARY

Updated message handling for update operations to skip message objects with missing MessageId properties. While this is invalid, it's easy to handle and just move on to other messages to surface to the user.

Fix #7465

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

redfish_utils, redfish_command

ADDITIONAL INFORMATION

Output after change.

ok: [localhost] => {
    "redfish_results": {
        "ansible_facts": {
            "discovered_interpreter_python": "/usr/bin/python3"
        },
        "changed": true,
        "failed": false,
        "msg": "Action was successful",
        "return_values": {
            "update_status": {
                "handle": <REDACTED>,
                "messages": [],
                "resets_requested": [],
                "ret": true,
                "status": "New"
            }
        },
        "session": {}
    }
}

…ge objects with missing MessageId properties

Signed-off-by: Mike Raineri <michael.raineri@dell.com>
@ansibullbot
Copy link
Collaborator

@ansibullbot ansibullbot added bug This issue/PR relates to a bug module_utils module_utils plugins plugin (any type) labels Nov 3, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch labels Nov 3, 2023
@felixfontein
Copy link
Collaborator

recheck

Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll merge this beginning of the upcoming week if nobody objects.

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 6, 2023
@felixfontein felixfontein merged commit ab0b85d into ansible-collections:main Nov 6, 2023
119 checks passed
Copy link

patchback bot commented Nov 6, 2023

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/ab0b85d7d2196e36c00cf4316c55582bad3b53f3/pr-7471

Backported as #7491

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 6, 2023
…ge objects with missing MessageId properties (#7471)

* Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties

Signed-off-by: Mike Raineri <michael.raineri@dell.com>

* Update 7465-redfish-firmware-update-message-id-hardening.yml

---------

Signed-off-by: Mike Raineri <michael.raineri@dell.com>
(cherry picked from commit ab0b85d)
Copy link

patchback bot commented Nov 6, 2023

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/ab0b85d7d2196e36c00cf4316c55582bad3b53f3/pr-7471

Backported as #7492

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@mraineri thanks a lot for this fix!

patchback bot pushed a commit that referenced this pull request Nov 6, 2023
…ge objects with missing MessageId properties (#7471)

* Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties

Signed-off-by: Mike Raineri <michael.raineri@dell.com>

* Update 7465-redfish-firmware-update-message-id-hardening.yml

---------

Signed-off-by: Mike Raineri <michael.raineri@dell.com>
(cherry picked from commit ab0b85d)
felixfontein pushed a commit that referenced this pull request Nov 6, 2023
…ing for update operations to skip message objects with missing MessageId properties (#7491)

Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties (#7471)

* Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties

Signed-off-by: Mike Raineri <michael.raineri@dell.com>

* Update 7465-redfish-firmware-update-message-id-hardening.yml

---------

Signed-off-by: Mike Raineri <michael.raineri@dell.com>
(cherry picked from commit ab0b85d)

Co-authored-by: Mike Raineri <mraineri@gmail.com>
felixfontein pushed a commit that referenced this pull request Nov 6, 2023
…ing for update operations to skip message objects with missing MessageId properties (#7492)

Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties (#7471)

* Redfish: Updated message handling for update operations to skip message objects with missing MessageId properties

Signed-off-by: Mike Raineri <michael.raineri@dell.com>

* Update 7465-redfish-firmware-update-message-id-hardening.yml

---------

Signed-off-by: Mike Raineri <michael.raineri@dell.com>
(cherry picked from commit ab0b85d)

Co-authored-by: Mike Raineri <mraineri@gmail.com>
@mraineri mraineri deleted the Redfish-Task-Message-Hardening branch May 17, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug module_utils module_utils plugins plugin (any type)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError: 'MessageId' in community.general.redfish_command (SimpleUpdate)
3 participants