Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isinstance() instead of type() #7501

Merged
merged 2 commits into from
Nov 8, 2023
Merged

Use isinstance() instead of type() #7501

merged 2 commits into from
Nov 8, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

Fix sanity tests.

Ref: https://dev.azure.com/ansible/community.general/_build/results?buildId=95127&view=logs&j=989d489a-4f0d-5fce-ef97-861a3aa8f466&t=7f12bb05-38e3-5790-48be-85ee2e060d6b

ISSUE TYPE
  • Bugfix Pull Request
  • Test Pull Request
COMPONENT NAME

several module utils

@felixfontein felixfontein added backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch labels Nov 8, 2023
@felixfontein felixfontein merged commit 48e860b into ansible-collections:main Nov 8, 2023
118 of 119 checks passed
@patchback Patchback
Copy link

patchback bot commented Nov 8, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/48e860be2033dc96127127d4355311301a6b31fa/pr-7501

Backported as #7502

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 8, 2023
@felixfontein @patchback
Use isinstance() instead of type() (#7501)
3a0c13a 
* Replace type comparisons with isinstance() checks.

* Add changelog.

(cherry picked from commit 48e860b)
@patchback patchback bot mentioned this pull request Nov 8, 2023
Merged
@patchback Patchback
Copy link

patchback bot commented Nov 8, 2023 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/48e860be2033dc96127127d4355311301a6b31fa/pr-7501

Backported as #7503

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Nov 8, 2023
@felixfontein @patchback
Use isinstance() instead of type() (#7501)
6165901 
* Replace type comparisons with isinstance() checks.

* Add changelog.

(cherry picked from commit 48e860b)
@patchback patchback bot mentioned this pull request Nov 8, 2023
Merged
felixfontein added a commit that referenced this pull request Nov 8, 2023
@patchback @felixfontein
[PR #7501/48e860be backport][stable-7] Use isinstance() instead of ty…
1d6552e 
…pe() (#7502)

Use isinstance() instead of type() (#7501)

* Replace type comparisons with isinstance() checks.

* Add changelog.

(cherry picked from commit 48e860b)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Nov 8, 2023
@patchback @felixfontein
[PR #7501/48e860be backport][stable-8] Use isinstance() instead of ty…
4b84127 
…pe() (#7503)

Use isinstance() instead of type() (#7501)

* Replace type comparisons with isinstance() checks.

* Add changelog.

(cherry picked from commit 48e860b)

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@felixfontein