-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ssl.wrap_socket() was removed in Python 3.12 #7542
ssl.wrap_socket() was removed in Python 3.12 #7542
Conversation
6432af0
to
28cb1ae
Compare
The FreeBSD failure is unrelated, see #7543. |
Restarting CI. |
28cb1ae
to
7a00386
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for doing this, @felixfontein! Appreciated. shipit |
I pushed a commit which makes the IRC module backwards-compatible (i.e. not secure). I think it's best to change this in the future; for that it's best IMO to add a |
@mariolenz @jpmens can you take another look with the latest commit? Thanks! |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Backport to stable-7: 💚 backport PR created✅ Backport PR branch: Backported as #7556 🤖 @patchback |
* ssl.wrap_socket() was removed in Python 3.12. * Make code for irc module backwards-compatible. (cherry picked from commit 21cd65f)
Backport to stable-8: 💚 backport PR created✅ Backport PR branch: Backported as #7557 🤖 @patchback |
@mariolenz @jpmens thanks a lot for reviewing this! |
* ssl.wrap_socket() was removed in Python 3.12. * Make code for irc module backwards-compatible. (cherry picked from commit 21cd65f)
* ssl.wrap_socket() was removed in Python 3.12. * Make code for irc module backwards-compatible.
SUMMARY
The irc module and the log_entries callback were still using it.
ISSUE TYPE
COMPONENT NAME
irc module
log_entries callback