Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssl.wrap_socket() was removed in Python 3.12 #7542

Merged
merged 2 commits into from
Nov 19, 2023
Merged

ssl.wrap_socket() was removed in Python 3.12 #7542

merged 2 commits into from
Nov 19, 2023

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

The irc module and the log_entries callback were still using it.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

irc module
log_entries callback

@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch labels Nov 18, 2023
@ansibullbot
Copy link
Collaborator

cc @jpmens @sivel
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug callback callback plugin module module plugins plugin (any type) labels Nov 18, 2023
@felixfontein
Copy link
Collaborator Author

The FreeBSD failure is unrelated, see #7543.

@ansibullbot ansibullbot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR label Nov 18, 2023
@felixfontein
Copy link
Collaborator Author

Restarting CI.

@felixfontein felixfontein reopened this Nov 18, 2023
mariolenz
mariolenz approved these changes Nov 18, 2023
View reviewed changes
Copy link
Contributor

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariolenz mariolenz mentioned this pull request Nov 18, 2023
Closed
@jpmens
Copy link
Contributor

jpmens commented Nov 18, 2023

Thank you for doing this, @felixfontein! Appreciated.

shipit

@felixfontein
Copy link
Collaborator Author

I pushed a commit which makes the IRC module backwards-compatible (i.e. not secure). I think it's best to change this in the future; for that it's best IMO to add a validate_certs option; deprecate it's default false after some time, and change it to true eventually.

@ansibullbot ansibullbot added has_issue and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Nov 18, 2023
@felixfontein felixfontein mentioned this pull request Nov 18, 2023
Merged
@felixfontein
Copy link
Collaborator Author

@mariolenz @jpmens can you take another look with the latest commit? Thanks!

@jpmens
Copy link
Contributor

jpmens commented Nov 19, 2023

LGTM

mariolenz
mariolenz approved these changes Nov 19, 2023
View reviewed changes
Copy link
Contributor

@mariolenz mariolenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Nov 19, 2023
@felixfontein felixfontein merged commit 21cd65f into ansible-collections:main Nov 19, 2023
125 checks passed
@patchback Patchback
Copy link

patchback bot commented Nov 19, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/21cd65fccf41d3c365572ec7f443214ba474f125/pr-7542

Backported as #7556

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the wrap_socket branch November 19, 2023 13:11
patchback bot pushed a commit that referenced this pull request Nov 19, 2023
@felixfontein @patchback
ssl.wrap_socket() was removed in Python 3.12 (#7542)
e4bfd13 
* ssl.wrap_socket() was removed in Python 3.12.

* Make code for irc module backwards-compatible.

(cherry picked from commit 21cd65f)
@patchback patchback bot mentioned this pull request Nov 19, 2023
Merged
@patchback Patchback
Copy link

patchback bot commented Nov 19, 2023 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/21cd65fccf41d3c365572ec7f443214ba474f125/pr-7542

Backported as #7557

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator Author

@mariolenz @jpmens thanks a lot for reviewing this!

patchback bot pushed a commit that referenced this pull request Nov 19, 2023
@felixfontein @patchback
ssl.wrap_socket() was removed in Python 3.12 (#7542)
3c69ccd 
* ssl.wrap_socket() was removed in Python 3.12.

* Make code for irc module backwards-compatible.

(cherry picked from commit 21cd65f)
@patchback patchback bot mentioned this pull request Nov 19, 2023
Merged
felixfontein added a commit that referenced this pull request Nov 19, 2023
@patchback @felixfontein
[PR #7542/21cd65fc backport][stable-7] ssl.wrap_socket() was removed …
a70de88 
…in Python 3.12 (#7556)

ssl.wrap_socket() was removed in Python 3.12 (#7542)

* ssl.wrap_socket() was removed in Python 3.12.

* Make code for irc module backwards-compatible.

(cherry picked from commit 21cd65f)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Nov 19, 2023
@patchback @felixfontein
[PR #7542/21cd65fc backport][stable-8] ssl.wrap_socket() was removed …
7f8d77b 
…in Python 3.12 (#7557)

ssl.wrap_socket() was removed in Python 3.12 (#7542)

* ssl.wrap_socket() was removed in Python 3.12.

* Make code for irc module backwards-compatible.

(cherry picked from commit 21cd65f)

Co-authored-by: Felix Fontein <felix@fontein.de>
samdoran pushed a commit to samdoran/community.general that referenced this pull request Nov 21, 2023
@felixfontein @samdoran
ssl.wrap_socket() was removed in Python 3.12 (ansible-collections#7542)
86970d4 
* ssl.wrap_socket() was removed in Python 3.12.

* Make code for irc module backwards-compatible.
@patchback patchback bot mentioned this pull request Nov 22, 2023
Merged
@felixfontein felixfontein mentioned this pull request Nov 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mariolenz mariolenz mariolenz approved these changes

Assignees
No one assigned
Labels
backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug callback callback plugin has_issue module module plugins plugin (any type) shipit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @ansibullbot @jpmens @mariolenz