Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

keycloak_user: avoid error when trying to delete a non-existing user #7696

Merged
merged 4 commits into from
Dec 21, 2023
Merged

keycloak_user: avoid error when trying to delete a non-existing user #7696

merged 4 commits into from
Dec 21, 2023

Conversation

michield
Copy link
Contributor

@michield michield commented Dec 6, 2023 •
edited
Loading

when force is set, but the user doesn't exist yet, this fails.

SUMMARY

Tiny fix to avoid trying to delete a user that may not exist

trivial:

  • keycloak_user: avoid deleting non-existent user
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

keycloak_user

ADDITIONAL INFORMATION

@michield
avoid error when trying to delete a non-existing user
381456e 
when force is set, but the user doesn't exist yet, this fails.
@ansibullbot
Copy link
Collaborator

cc @eikef @elfelip @mattock @ndclt
click here for bot help

@ansibullbot ansibullbot added WIP Work in progress bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) small_patch Hopefully easy to review labels Dec 6, 2023
@felixfontein felixfontein added check-before-release PR will be looked at again shortly before release and merged if possible. backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch labels Dec 6, 2023
felixfontein
felixfontein reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@felixfontein felixfontein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

@michield
Copy link
Contributor Author

michield commented Dec 6, 2023

Thanks for your contribution! Could you please add a changelog fragment? Thanks.

Sorry, first time contributing here. Have added the trivial tag, hope I did it correctly.

@michield michield marked this pull request as ready for review December 6, 2023 17:52
@ansibullbot ansibullbot removed the WIP Work in progress label Dec 6, 2023
@felixfontein
Copy link
Collaborator

@michield since this is a bugfix it should be bugfixes:. The trivial: section is reserved for things that shouldn't show up in the user-facing changelog.

Also in case you added a commit, you didn't push it :)

@michield
Copy link
Contributor Author

michield commented Dec 6, 2023

@michield since this is a bugfix it should be bugfixes:. The trivial: section is reserved for things that shouldn't show up in the user-facing changelog.

Also in case you added a commit, you didn't push it :)

Ah, hang on. I need to read better. I added it to the description of this PR. I'll make it bugfix and will add the commit to this PR.

@michield
Copy link
Contributor Author

michield commented Dec 7, 2023

ok, done

@ansibullbot

This comment was marked as outdated.

Sign in to view
@ansibullbot ansibullbot added ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR and removed small_patch Hopefully easy to review labels Dec 7, 2023
@ansibullbot

This comment was marked as outdated.

Sign in to view
@michield @felixfontein
Update changelogs/fragments/7696-avoid-attempt-to-delete-non-existing…
ef72c57 
…-user.yml

Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibullbot ansibullbot removed ci_verified Push fixes to PR branch to re-run CI needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR labels Dec 8, 2023
@felixfontein felixfontein changed the title avoid error when trying to delete a non-existing user keycloak_user: avoid error when trying to delete a non-existing user Dec 8, 2023
@felixfontein
Copy link
Collaborator

If nobody objects in the next ~two weeks, I'll merge this.

@ansibullbot ansibullbot added the stale_ci CI is older than 7 days, rerun before merging label Dec 16, 2023
@felixfontein felixfontein removed the check-before-release PR will be looked at again shortly before release and merged if possible. label Dec 21, 2023
@felixfontein felixfontein merged commit 1389bba into ansible-collections:main Dec 21, 2023
122 checks passed
@patchback Patchback
Copy link

patchback bot commented Dec 21, 2023 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/1389bba4596d8dc062b7b058907d3bd294c85040/pr-7696

Backported as #7755

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein
Copy link
Collaborator

@michield thanks for your contribution!

patchback bot pushed a commit that referenced this pull request Dec 21, 2023
@michield @patchback
keycloak_user: avoid error when trying to delete a non-existing user (#…
8ec7809 
…7696)

* avoid error when trying to delete a non-existing user

when force is set, but the user doesn't exist yet, this fails.

* 7696-avoid-attempt-to-delete-non-existing-user

add changelog entry

* rename changelog file

* Update changelogs/fragments/7696-avoid-attempt-to-delete-non-existing-user.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 1389bba)
@patchback patchback bot mentioned this pull request Dec 21, 2023
Merged
@patchback Patchback
Copy link

patchback bot commented Dec 21, 2023 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/1389bba4596d8dc062b7b058907d3bd294c85040/pr-7696

Backported as #7756

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Dec 21, 2023
@michield @patchback
keycloak_user: avoid error when trying to delete a non-existing user (#…
f0901ea 
…7696)

* avoid error when trying to delete a non-existing user

when force is set, but the user doesn't exist yet, this fails.

* 7696-avoid-attempt-to-delete-non-existing-user

add changelog entry

* rename changelog file

* Update changelogs/fragments/7696-avoid-attempt-to-delete-non-existing-user.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 1389bba)
@patchback patchback bot mentioned this pull request Dec 21, 2023
Merged
felixfontein pushed a commit that referenced this pull request Dec 21, 2023
@patchback @michield
[PR #7696/1389bba4 backport][stable-7] keycloak_user: avoid error whe…
f47fced 
…n trying to delete a non-existing user (#7755)

keycloak_user: avoid error when trying to delete a non-existing user (#7696)

* avoid error when trying to delete a non-existing user

when force is set, but the user doesn't exist yet, this fails.

* 7696-avoid-attempt-to-delete-non-existing-user

add changelog entry

* rename changelog file

* Update changelogs/fragments/7696-avoid-attempt-to-delete-non-existing-user.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 1389bba)

Co-authored-by: Michiel Dethmers <michiel@phplist.com>
felixfontein pushed a commit that referenced this pull request Dec 21, 2023
@patchback @michield
[PR #7696/1389bba4 backport][stable-8] keycloak_user: avoid error whe…
293aee5 
…n trying to delete a non-existing user (#7756)

keycloak_user: avoid error when trying to delete a non-existing user (#7696)

* avoid error when trying to delete a non-existing user

when force is set, but the user doesn't exist yet, this fails.

* 7696-avoid-attempt-to-delete-non-existing-user

add changelog entry

* rename changelog file

* Update changelogs/fragments/7696-avoid-attempt-to-delete-non-existing-user.yml

Co-authored-by: Felix Fontein <felix@fontein.de>

---------

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit 1389bba)

Co-authored-by: Michiel Dethmers <michiel@phplist.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug module module new_contributor Help guide this first time contributor plugins plugin (any type) stale_ci CI is older than 7 days, rerun before merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@michield @ansibullbot @felixfontein