Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mssql_script: make module Python 2 compatible #7821

Merged
merged 1 commit into from
Jan 18, 2024
Merged

mssql_script: make module Python 2 compatible #7821

merged 1 commit into from
Jan 18, 2024

Conversation

felixfontein
Copy link
Collaborator

SUMMARY

splitlines() does not accept kwargs on Python 2, only positional parameters.

Fixes #7818.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

mssql_script

@felixfontein felixfontein added backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch labels Jan 9, 2024
@felixfontein felixfontein mentioned this pull request Jan 9, 2024
Closed
1 task
@ansibullbot
Copy link
Collaborator

cc @kbudde
click here for bot help

@ansibullbot ansibullbot added bug This issue/PR relates to a bug has_issue module module plugins plugin (any type) labels Jan 9, 2024
@felixfontein felixfontein merged commit 92f8bf7 into ansible-collections:main Jan 18, 2024
119 checks passed
@patchback Patchback
Copy link

patchback bot commented Jan 18, 2024 •
edited
Loading

Backport to stable-7: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-7/92f8bf7b6f4e4f7fdb2d9fca58dd83f653146913/pr-7821

Backported as #7865

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@felixfontein felixfontein deleted the splitlines branch January 18, 2024 06:12
patchback bot pushed a commit that referenced this pull request Jan 18, 2024
@felixfontein @patchback
mssql_script: make module Python 2 compatible (#7821)
4f7f746 
Make module Python 2 compatible.

(cherry picked from commit 92f8bf7)
@felixfontein
Copy link
Collaborator Author

@markuman thanks for reviewing this!

@patchback patchback bot mentioned this pull request Jan 18, 2024
Merged
@patchback Patchback
Copy link

patchback bot commented Jan 18, 2024 •
edited
Loading

Backport to stable-8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-8/92f8bf7b6f4e4f7fdb2d9fca58dd83f653146913/pr-7821

Backported as #7866

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Jan 18, 2024
@felixfontein @patchback
mssql_script: make module Python 2 compatible (#7821)
4046081 
Make module Python 2 compatible.

(cherry picked from commit 92f8bf7)
@patchback patchback bot mentioned this pull request Jan 18, 2024
Merged
felixfontein added a commit that referenced this pull request Jan 18, 2024
@patchback @felixfontein
[PR #7821/92f8bf7b backport][stable-7] mssql_script: make module Pyth…
8bc51bb 
…on 2 compatible (#7865)

mssql_script: make module Python 2 compatible (#7821)

Make module Python 2 compatible.

(cherry picked from commit 92f8bf7)

Co-authored-by: Felix Fontein <felix@fontein.de>
felixfontein added a commit that referenced this pull request Jan 18, 2024
@patchback @felixfontein
[PR #7821/92f8bf7b backport][stable-8] mssql_script: make module Pyth…
d22199f 
…on 2 compatible (#7866)

mssql_script: make module Python 2 compatible (#7821)

Make module Python 2 compatible.

(cherry picked from commit 92f8bf7)

Co-authored-by: Felix Fontein <felix@fontein.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuman markuman markuman approved these changes

Assignees
No one assigned
Labels
backport-7 Automatically create a backport for the stable-7 branch backport-8 Automatically create a backport for the stable-8 branch bug This issue/PR relates to a bug has_issue module module plugins plugin (any type)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

community.general.mssql_script TypeError: splitlines() takes no keyword arguments
3 participants
@felixfontein @ansibullbot @markuman